Opened 11 years ago

Closed 11 years ago

#3733 closed enhancement (fixed)

re-implement Deskbar's restart+shutdown functionality

Reported by: mmadia Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/Deskbar Version: R1/pre-alpha1
Keywords: Cc: mdisreali@…
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Currently in rev30000 Deskbar displays "Restart" and "Shutdown" as options. Clicking these will display a confirmation alert -- to prevent accidental clicks in Deskbar.

The plan is to change that alert to show the options (Restart vs. Shutdown), and have only one entry for this in the Deskbar.

Attachments (1)

patch_deskbar (2.1 KB ) - added by stpere 11 years ago.

Download all attachments as: .zip

Change History (11)

by stpere, 11 years ago

Attachment: patch_deskbar added

comment:1 by stpere, 11 years ago

Here, I prepared that small patch..

I combined the "Shut down..." and "Restart..." items into a new "End session..." item.

Clicking that new item shows an Alert asking the user what to do (shutdown or restart).

I can commit, but I prefered to propose it here first.

comment:2 by stpere, 11 years ago

An alternative way to present this functionality would be to have the shutdown item be a submenu with 2 items : shut down and restart.. with or without further confirmation.

in reply to:  2 comment:3 by mmadia, 11 years ago

Replying to stpere:

An alternative way to present this functionality would be to have the shutdown item be a submenu with 2 items : shut down and restart.. with or without further confirmation.

I don't recall which ticket this was pulled from, but the idea is to: -present a more logical & less insulting order of confirmations. eg, "End Session" --> "shutdown, restart, cancel". vs the current "shutdown"-->"are you sure you didn't click this by accident? yes,no"

-ensure that a user doesn't accidentally end their session my an accidental click in Deskbar.

So, from my understanding, having the entries as a submenu would increase the chances of an accidental shutdown in comparison to your first patch/comment.

comment:4 by humdinger, 11 years ago

I'm with Matt here. Your first idea with the alert is better.

With respect to the future, an alert may not be the way either, however. One day Haiku may be multi-user, then having a panel with clearly labeled radio buttons would be necessary:

"[nice icon] End Session and

  • Shutdown
  • Restart
  • Suspend
  • Log out
  • Switch user

[Cancel] [OK]"

Cursor-Up/Down moves the radio button selection. ESC cancels, RETURN OKs. Last used position is remembered.

[Hmmm. It would be nice if things like radio buttons, check boxes, sliders, text boxes etc. would become available in a scripting command like "alert".]

comment:5 by siarzhuk, 11 years ago

Preface: For 10 years with BeOS I have never shutdowned or restarted it by accident. But for some years with Haiku I have OKeyed this confirmation alerts many thousands times. And I really hate this alert boxes! :-D I love BeOS because it doesn't ask me too much for obvious things.

Well, let's look on the problem: someone think that many users have problems with fine hand movements and decisions - and they can "accidentally" select the "Shutdown/Restart" menu entries from the main Haiku menu. Well, I can agree that main menu is a common place and some more protection can be useful here. But IMO, neither current confirmation alerts nor proposed windows-like full-blown dialog boxes can be lightweight and acceptable solutions.

My proposition: Shutdown and Restart menu entries should be replaced with following:

End of Session... -> Restart
                  -> Shutdown

or with this one: (thanks to humdinger for thinking about the feature)

End of Session... -> Restart
                  -> Shutdown
                  -> Suspend
                  -> Log out
                  -> Switch user 

Pro:

1) it is lightweight and is not over-complicate.

2) it is a BeOS/Haiku way of things. Remember, most of operations in Tracker are performed from context menu. Rebooting from the sub-menu is absolutely natural for typical Tracker user.

3) in proposed solution accidental reboot of the system can occur when user "accidentally" go to "End of Session..." sub-menu and "accidentially" click some menu entry there. I can't imagine this as unintentional action.

4) it save a miles of mouse movements and thousands mouse clicks! Actually you need to select the "Reboot" menu entry, move mouse pointer at least 6 inches to the center of the display, locate mouse on OK button and finally click it. The solution, proposed by me require about 2 inches of mouse movements and single click! It saves more than 4 inches and one click pro every reboot. :-D

5) it doesn't irritate the user with obvious confirmation alerts.

Contra:

1) it is still possible to "accidentally" reboot the system from the main menu by selecting "wrong" menu entry. Yes, windows refugee can be surprised with such easy way of reboot. Well - we can add the option "Ask the user before shutdown the system" into Tracker options to make both beginners and veterans happy. :-)

2) ??

3) ??

comment:6 by humdinger, 11 years ago

Hey, calling the dialog "windows-like" was below the belt. :)

Maybe it's because I'm working with a notebook and moving the mouse pointer a few pixels to aim it at the right submenu is a bit tricky at times... I'd still prefer the dialog solution:
It's one click on the "End Session..." menu (maybe we'll have a shortcut one day (or SpiceyKeys)) and hitting "RETURN" as the panel remembers the last setting and in my experience it's "shutdown" 99% of the times.

Why not have an "End Session" cake and eat it, too?
It could be implemented like the "Open Recent >" menu item: moving the mouse over it reveals the power-using submenu, but clicking the "End Session" itself will open the glorious dialog.

in reply to:  6 comment:7 by siarzhuk, 11 years ago

Replying to humdinger:

Hey, calling the dialog "windows-like" was below the belt. :)

What is wrong?

It's one click on the "End Session..." menu (maybe we'll have a shortcut one day (or SpiceyKeys)) and hitting "RETURN" as the panel remembers the last setting and in my experience it's "shutdown" 99% of the times.

Are you lefthander? ;-)

Why not have an "End Session" cake and eat it, too?
It could be implemented like the "Open Recent >" menu item: moving the mouse over it reveals the power-using submenu, but clicking the "End Session" itself will open the glorious dialog.

Nice idea! But IMHO "the Tracker way" is the using most perfect solutions without over-bloating binaries and "thrashing" memory with never-used code. Anyway I'm not against your solution. :-)

I have reposted my proposition into [haiku-development]. Probably it is a better idea to make a discussion in that mail list. :-)

comment:8 by humdinger, 11 years ago

Hey, calling the dialog "windows-like" was below the belt. :)

What is wrong?

Sorry, I thought you meant Microsoft Windows. :)

I have reposted my proposition into [haiku-development]

So I've seen. This is the thread.

comment:9 by Disreali, 11 years ago

Cc: mdisreali@… added

comment:10 by mmadia, 11 years ago

Resolution: fixed
Status: newclosed

implemented in Changeset [30512] by kirilla

Note: See TracTickets for help on using tickets.