Opened 10 years ago

Closed 10 years ago

#3740 closed bug (fixed)

Fix ape_reader build under gcc4

Reported by: pulkomandy Owned by: marcusoverhagen
Priority: normal Milestone: R1
Component: Audio & Video/Codecs Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Here is a patch for ape_reader so it builds with gcc4. Apply it under src/add-ons/media/plugings/ape_reader Thanks :)

Attachments (1)

ape_reader.gcc4.patch (7.5 KB ) - added by pulkomandy 10 years ago.
Patch for gcc4 build

Download all attachments as: .zip

Change History (4)

by pulkomandy, 10 years ago

Attachment: ape_reader.gcc4.patch added

Patch for gcc4 build

comment:1 by umccullough, 10 years ago

Unfortunately, it seems when I apply this patch to my tree, it breaks gcc2 build:

C++ /work/haiku/haiku/trunk/generated-gcc2/objects/haiku/x86/release/add-ons/media/plugins/ape_reader/MAClib/APEDecompress.o
In file included from /work/haiku/haiku/trunk/headers/cpp/stl_algobase.h:45,
                 from /work/haiku/haiku/trunk/headers/cpp/algorithm:30,
                 from /work/haiku/haiku/trunk/src/add-ons/media/plugins/ape_reader/MAClib/APEDecompress.cpp:4:
/work/haiku/haiku/trunk/headers/cpp/type_traits.h:132: redefinition of `struct __type_traits<char>'
/work/haiku/haiku/trunk/headers/cpp/type_traits.h:112: previous definition here
/work/haiku/haiku/trunk/headers/cpp/type_traits.h:132: explicit specialization of non-template `__type_traits<char>'
/work/haiku/haiku/trunk/headers/cpp/type_traits.h:138: confused by earlier errors, bailing out
cpp0: output pipe has been closed

/work/haiku/haiku/trunk/generated-gcc2/cross-tools/bin/i586-pc-haiku-gcc -c "/work/haiku/haiku/trunk/src/add-ons/media/plugins/ape_reader/MAClib/APEDecompress.cpp" -O -Wall -Wno-trigraphs -Wno-ctor-dtor-privacy -Woverloaded-virtual -Wpointer-arith -Wcast-align -Wsign-compare -Wno-multichar -pipe -nostdinc -D_ZETA_USING_DEPRECATED_API_=1 -D_ZETA_TS_FIND_DIR_=1 -D__HAIKU__ -DHAIKU_DISTRO_COMPATIBILITY_DEFAULT -D__INTEL__ -DARCH_x86 -DBOOT_ARCHIVE_IMAGE_OFFSET=300 -D_BEOS_R5_COMPATIBLE_ -DHAIKU_TARGET_PLATFORM_HAIKU -I/work/haiku/haiku/trunk/build/user_config_headers -I/work/haiku/haiku/trunk/build/config_headers -I/work/haiku/haiku/trunk/src/add-ons/media/plugins/ape_reader/MAClib -I/work/haiku/haiku/trunk/generated-gcc2/objects/common/add-ons/media/plugins/ape_reader/MAClib -I/work/haiku/haiku/trunk/generated-gcc2/objects/linux/x86/common/add-ons/media/plugins/ape_reader/MAClib -I/work/haiku/haiku/trunk/generated-gcc2/objects/haiku/x86/common/add-ons/media/plugins/ape_reader/MAClib -I/work/haiku/haiku/trunk/src/add-ons/media/plugins/ape_reader/MAClib/../LibMonkeysAudio -I- -I/work/haiku/haiku/trunk/headers/cpp -I/work/haiku/haiku/trunk/headers/build/gcc-2.95.3 -I/work/haiku/haiku/trunk/headers -I/work/haiku/haiku/trunk/headers/posix -I/work/haiku/haiku/trunk/headers/gnu -I/work/haiku/haiku/trunk/headers/glibc -I/work/haiku/haiku/trunk/headers/os -I/work/haiku/haiku/trunk/headers/os/add-ons -I/work/haiku/haiku/trunk/headers/os/add-ons/file_system -I/work/haiku/haiku/trunk/headers/os/add-ons/graphics -I/work/haiku/haiku/trunk/headers/os/add-ons/input_server -I/work/haiku/haiku/trunk/headers/os/add-ons/registrar -I/work/haiku/haiku/trunk/headers/os/add-ons/screen_saver -I/work/haiku/haiku/trunk/headers/os/add-ons/tracker -I/work/haiku/haiku/trunk/headers/os/app -I/work/haiku/haiku/trunk/headers/os/device -I/work/haiku/haiku/trunk/headers/os/drivers -I/work/haiku/haiku/trunk/headers/os/game -I/work/haiku/haiku/trunk/headers/os/interface -I/work/haiku/haiku/trunk/headers/os/kernel -I/work/haiku/haiku/trunk/headers/os/media -I/work/haiku/haiku/trunk/headers/os/mail -I/work/haiku/haiku/trunk/headers/os/midi -I/work/haiku/haiku/trunk/headers/os/midi2 -I/work/haiku/haiku/trunk/headers/os/net -I/work/haiku/haiku/trunk/headers/os/opengl -I/work/haiku/haiku/trunk/headers/os/storage -I/work/haiku/haiku/trunk/headers/os/support -I/work/haiku/haiku/trunk/headers/os/translation -I/work/haiku/haiku/trunk/headers/private/. -o "/work/haiku/haiku/trunk/generated-gcc2/objects/haiku/x86/release/add-ons/media/plugins/ape_reader/MAClib/APEDecompress.o" ;

...failed C++ /work/haiku/haiku/trunk/generated-gcc2/objects/haiku/x86/release/add-ons/media/plugins/ape_reader/MAClib/APEDecompress.o ...

It does at least work for me when compiling gcc4 though.

comment:2 by umccullough, 10 years ago

Looks like this can probably be closed with hrev30136 followed by hrev30138

comment:3 by anevilyak, 10 years ago

Resolution: fixed
Status: newclosed

Indeed, forgot there was an open ticket for that.

Note: See TracTickets for help on using tickets.