Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3743 closed enhancement (invalid)

[PATCH] Add yasm to configure --build-cross-tools

Reported by: umccullough Owned by: bonefish
Priority: normal Milestone: R1
Component: Build System Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Platform: All


Since a recent version of yasm is now in the buildtools/trunk, and there are several targets in the Haiku repo that require yasm to build for x86, I have put together a patch that builds yasm when the configure --build-cross-tools[-gcc4] is invoked.

This patch has a couple issues, but does work on two of my Linux machines here, using both gcc2 and gcc4 cross tools.

Issue 1: It prefixes the binary with i586-pc-haiku- when that is mostly unnecessary (since there isn't anything inherently haiku-specific about the yasm that is built).

Issue 2: It will build yasm even for non-x86 targets when using --build-cross-tools-gcc4

Issue 3: It hasn't been tested on other environments yet, nor on a native Haiku system... YMMV.

Attachments (1)

cross-build-tools-yasm.diff (4.7 KB ) - added by umccullough 12 years ago.
patch to add yasm to cross-tools creation

Download all attachments as: .zip

Change History (3)

by umccullough, 12 years ago

Attachment: cross-build-tools-yasm.diff added

patch to add yasm to cross-tools creation

comment:1 by bonefish, 12 years ago

Resolution: invalid
Status: newclosed

As of hrev30146 yasm is no longer in the buildtools module. Since hrev30145 configure checks the yasm version and points to the official download location.

comment:2 by luroh, 12 years ago

Thanks! Do you reckon it would be possible to accommodate for yasm 0.7.0 and 0.7.1 as well? PulkoMandy has reported successful compilation with 0.7.0 and so can I with 0.7.1 (Ubuntu Intrepid and Jaunty). I noticed that you made special provisions for those versions in trunk/configure, although the are currently not accepted. Of course, I cannot really say if compiling equals working without knowing what and how to test properly. That would be for dlmcpaul to advice on, I guess. Anyway, thanks for straighting things out.

Note: See TracTickets for help on using tickets.