Opened 11 years ago

Closed 11 years ago

#3759 closed bug (fixed)

In Fonts preferences in "Menu Font" no font size as default.

Reported by: maxime.simon Owned by: axeld
Priority: normal Milestone: R1
Component: Preferences Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

While changing the font size of "Menu Font", the "Defaults" button is never enabled.
(The behaviour of the "Defaults" button we want is the same as "Plain|Bold|Fixed Font")

Attachments (2)

Fonts Pref.png (41.6 KB ) - added by maxime.simon 11 years ago.
Menu Font set to 18 and "Defaults" button is disable.
3759.diff (1.0 KB ) - added by maxime.simon 11 years ago.
In system default font calls, considers the menu font as a plain font.

Download all attachments as: .zip

Change History (7)

by maxime.simon, 11 years ago

Attachment: Fonts Pref.png added

Menu Font set to 18 and "Defaults" button is disable.

comment:1 by maxime.simon, 11 years ago

After looking deep into the code it seems this is because "menu" is not a default font of the system as "plain", "fixed" or "bold".

What I suggest is to consider the "menu" font as a "plain" font in default system font calls.
We can also modify the system to add the "menu" font as a default system font. :)

by maxime.simon, 11 years ago

Attachment: 3759.diff added

In system default font calls, considers the menu font as a plain font.

comment:2 by stippi, 11 years ago

This patch is not correct. There is a way to retrieve the Menu font. This panel must already do this somewhere. So the code should be changed to special case the retrieval of the menu font, instead of retrieving the default plain font and never the menu font. It has nothing to do with there being no "be_menu_font".

comment:3 by stippi, 11 years ago

Wait, I may be missing something. This is only about default fonts, right? Not about Revert... in that case, the default menu font is indeed the same one as plain font. I am just wondering if where the default menu font is set for real outside of the preflet, it would always be in line.

comment:4 by maxime.simon, 11 years ago

Indeed it's about default fonts, not about Revert.
In the call to _get_system_default_font_ we pass "menu" as an argument (argument which should be a "be_font").
(That's the issue in the source code :)
(The issue for the end user is that there is no default font for the Menu Font.)

comment:5 by stippi, 11 years ago

Resolution: fixed
Status: newclosed

Applied in hrev30181. Thanks a lot!

Note: See TracTickets for help on using tickets.