Opened 10 years ago

Closed 5 years ago

#3763 closed enhancement (fixed)

libroot + some other stuff for ARM

Reported by: pfoetchen_ Owned by: axeld
Priority: normal Milestone: R1
Component: System/libroot.so Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: arm

Description

I got libroot to compile and some function should already work but this code is still far from usable and still contains a lot of unchanged m68k code ;)

Attachments (2)

libroot.diff (20.2 KB) - added by pfoetchen_ 10 years ago.
headers.diff (34.2 KB) - added by pfoetchen_ 10 years ago.
added/modified headers

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by pfoetchen_

Attachment: libroot.diff added

Changed 10 years ago by pfoetchen_

Attachment: headers.diff added

added/modified headers

comment:1 Changed 10 years ago by anevilyak

Component: - GeneralSystem/libroot.so
Type: bugenhancement

comment:2 Changed 10 years ago by bonefish

I just had a quick look at the diffs. There's lot of code copied from other ports -- which is OK -- but with a lot of unmodified left-overs from m86k and PPC. Please run through the patch again and adjust header guards, add your copyright where you've changed more than trivial stuff (and extend "Haiku Inc." copyrights to 2009), and remove stuff that doesn't apply. I'd rather see empty stubs with TODOs than copied code that doesn't apply (even if the m68k port does that, too).

Anyway, nice to see you make progress. Besides getting libroot compiling, I wouldn't concentrate too much on it yet, though. Before it becomes relevant at all (save for the parts that are used in the kernel (src/system/kernel/lib)) you have to get the kernel boot to the very end, which is the main chunk of the work.

comment:3 Changed 9 years ago by mmadia

Platform: Allarm

comment:4 Changed 5 years ago by pulkomandy

Can this ticket be closed?

comment:5 Changed 5 years ago by pfoetchen_

Yes the ticket can be closed. This is all included in the repository now.

comment:6 Changed 5 years ago by pulkomandy

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.