Opened 10 years ago

Closed 5 years ago

#3790 closed enhancement (fixed)

New proposal color chooser

Reported by: stpere Owned by: stpere
Priority: normal Milestone: R1
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc: leavengood@…
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

I propose a new behaviour for the color chooser.

Currently, the color bands in the color chooser goes from black to max {red,green,blue}. In the apparence preflet, it's ok, since we see the resulting color at the left.

But in other places, the preview isn't shown (as in terminal)

The new behaviour I propose (I think we have that behaviour in some graphical utilities - gnome or photoshop, I don't remember which) is to change the color of the color bands to show the possible values you can get.

For example, if you have 0 at red, 0 at green and 0 blue, the bands will continue to show as currently. Then if you move the red up a bit, the starting color of green and blue will be a red (as much of the currently selected value in the red band).

Ok, enough words, look at the screenies (or apply the patch and see) !

PS : As a side effect, it fixes the drawing artifacts mentioned in other tickets..

Attachments (2)

screenshot1.png (20.1 KB ) - added by stpere 10 years ago.
patch_colorcontrol (7.4 KB ) - added by stpere 10 years ago.

Download all attachments as: .zip

Change History (7)

by stpere, 10 years ago

Attachment: screenshot1.png added

by stpere, 10 years ago

Attachment: patch_colorcontrol added

comment:1 by leavengood, 10 years ago

Cc: leavengood@… added

I think this patch is pretty interesting in the behavior it introduces, but it seems to have a bug: it uses a lot of CPU from what I assume is a lot of calls to Invalidate(). Whenever a color control is showing the CPU is pegged, whenever it is hidden the CPU slows down.

So there is some flaw in the logic somewhere, I believe in _DrawSelector. Unfortunately I do not have time now to figure it out, but please take a look as I think this may be a worthwhile patch!

comment:2 by mmadia, 10 years ago

Owner: changed from axeld to stpere

comment:3 by diver, 7 years ago

Component: - GeneralKits/Interface Kit
Version: R1/pre-alpha1R1/Development

comment:4 by pulkomandy, 5 years ago

Has a Patch: set

comment:5 by pulkomandy, 5 years ago

Has a Patch: unset
Resolution: fixed
Status: newclosed

Done in hrev48477. Had to rewrite the patch, not sure about that "drawing artifacts" thing.

Note: See TracTickets for help on using tickets.