Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#3814 closed bug (fixed)

Screeshot options are not saved

Reported by: humdinger Owned by: stippi
Priority: normal Milestone: R1
Component: Applications/Screenshot Version: R1/pre-alpha1
Keywords: Cc: WPJvanderMeer@…
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev30234.

The settings in the "Options" panel are not saved. Only format and location of the main app panel.

Attachments (1)

screenshot-wim.patch (13.2 KB ) - added by Wim 9 years ago.
Patch to have the screenshot application save it's settings. I also cleaned up some style violations, mainly lines that where longer than 80 characters.

Download all attachments as: .zip

Change History (6)

comment:1 by Wim, 9 years ago

I confirmed that no settings are saved at all. There are functions present in the source code to read and write settings, but they are not called, and they do not handle all the settings.

I have started to work on this. If there is already someone else already working on it please let me know.

comment:2 by Wim, 9 years ago

Cc: WPJvanderMeer@… added

by Wim, 9 years ago

Attachment: screenshot-wim.patch added

Patch to have the screenshot application save it's settings. I also cleaned up some style violations, mainly lines that where longer than 80 characters.

comment:3 by stippi, 9 years ago

Owner: changed from julun to stippi
Status: newin-progress

Great quality patch.

comment:4 by stippi, 9 years ago

Resolution: fixed
Status: in-progressclosed

Applied in hrev36461. Thanks a bunch! You're on your best way to being proposed for commit access... :-)

comment:5 by humdinger, 9 years ago

Thanks, Wim! (& Stippi keeping an eye on applying finished patches)

Note: See TracTickets for help on using tickets.