media_addon_server error during Shutdown\Reboot.

[HaikuBot]

Always when I shutdown or reboot laptop with Haiku, I getting error(see attachments).

[korli]

Michael, could you have a look please ?

[axeld]

I doubt it has anything to do with USB, I would rather assume a problem in the media add-on server recently revealed by stippi's changes. I guess the add-on is unloaded early or something.

[stippi]

The changes I did have the effect that (reader and decoder) add-ons, which are no longer needed by the application, are indeed free'd. Before, any add-ons that the application actually used (i.e. more than for sniffing) would stay loaded even if a BMediaTrack/BMediaFile is released/deleted. So maybe it's something in that direction. The code in the plugin manager inside of libmedia (I think media_addon_server uses the same code) is very clean and not complex. I would not expect an error to come from there. It does little more than reference counting. I didn't have a close look a the media_addon_server code, though, I don't know if all plugin management there goes through the plugin manager. I did check libmedia, though, and there it's the case.

[mmlr]

It's a misuse of BUSBRoster. You have to Stop() the roster before deleting it, as it otherwise can't properly call the DeviceRemoved() hook. So before deleting the roster in the WebCamMediaAddOn destructor you simply call fRoster->Stop() first.

[mmlr]

Should be fixed in hrev31013. Please reopen if it still exists as I can't test it here.

[HaikuBot]

Thanks. All fine now.