Opened 10 years ago

Closed 7 years ago

#4125 closed bug (fixed)

NULL device is translated to '//'

Reported by: brecht Owned by: bonefish
Priority: normal Milestone: R1
Component: File Systems/UserlandFS Version: R1/pre-alpha1
Keywords: gsoc2012 Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

UserlandFS passes '' as the device to the FS when no device has been specified when mounting it.

source:haiku/trunk/src/add-ons/kernel/file_systems/userlandfs/server/UserlandRequestHandler.cpp@29872#L233

Attachments (2)

4125.patch (988 bytes) - added by pdziepak 7 years ago.
0001-Fix-4125-NULL-device-is-translated-to.patch (1.6 KB) - added by pdziepak 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by brecht

Component: File SystemsFile Systems/UserlandFS
Owner: changed from axeld to bonefish
Summary: [userlandfs] NULL device is translated to '//'NULL device is translated to '//'

Changed 7 years ago by pdziepak

Attachment: 4125.patch added

comment:2 Changed 7 years ago by pdziepak

Has a Patch: set

comment:3 Changed 7 years ago by pdziepak

Keywords: gsoc2012 added

The problem appeared to be on the request creating side (i.e. in the kernel add-on) which did not support NULL pointers properly.

Relocation of addresses in request when it is received translates offset = 0, size = 0 to pointer NULL so that no change in that part of code was required.

comment:4 Changed 7 years ago by bonefish

The patch looks good. Please provide it in git format-patch format. The null pointer check should be data != NULL though.

comment:5 Changed 7 years ago by bonefish

Resolution: fixed
Status: newclosed

Thanks, applied in hrev43968.

Note: See TracTickets for help on using tickets.