Opened 10 years ago

Closed 10 years ago

#4143 closed bug (fixed)

usb_hid: Pagefault in AddonMonitor on boot, r31838 and on

Reported by: tqh Owned by: mmlr
Priority: normal Milestone: R1
Component: Drivers/Keyboard/USB Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

revision 31838 crashes at Desktop with Pagefault in AddonMonitor. See screenshot. hrev31837 and earlier works fine. Stack trace as image.

Note, my usb is a bit problematic with usb sticks and other things too, so I might need to look into that. Still, it worked before.

Attachments (4)

sc_20090728.gif (88.0 KB ) - added by tqh 10 years ago.
stacktrace
usb-devices.txt (20.8 KB ) - added by tqh 10 years ago.
lsusb -v in linux
haiku-crash.jpg (326.4 KB ) - added by Blub 10 years ago.
backtrace in rev 31935 freshly installed gcc4-only
haiku_r31915_fix_usb_hid_wrong_pointer_access.diff (558 bytes ) - added by Blub 10 years ago.
this fixed it for me - it's one of those "trivial but hard to find" cases :P

Download all attachments as: .zip

Change History (10)

by tqh, 10 years ago

Attachment: sc_20090728.gif added

stacktrace

comment:1 by mmlr, 10 years ago

Component: Drivers/USBDrivers/Keyboard/USB

Actually the stack trace is missing from that image. I assume you're using the auto_stack_trace kernel debugger add-on which sometimes exhibits that problem. If you would be able to get a full stack trace that would be most helpful. Can you provide info about the kind of keyboard that you have attached to that machine? Does it have special keys at all or is it a more simple model?

comment:2 by tqh, 10 years ago

Probably should have done so in the first place. I have a usb mouse (wireless) and a usb keyboard connected to a usb hub, which in turn is connected to the PC. The usb-keyboard is a cheap noname brand, but has sleep, hibernate and power button (never checked if they work in any OS). lsusb in Linux suggest usb to ps/2 converter. Attaching info from lsusb -v.

by tqh, 10 years ago

Attachment: usb-devices.txt added

lsusb -v in linux

by Blub, 10 years ago

Attachment: haiku-crash.jpg added

backtrace in rev 31935 freshly installed gcc4-only

by Blub, 10 years ago

this fixed it for me - it's one of those "trivial but hard to find" cases :P

comment:3 by Blub, 10 years ago

attached a diff which should fix the problem [] is executed before the preceeding dereferencing * parentheses fixed the problem

runs fine again here :)

comment:4 by mmlr, 10 years ago

Nice catch definitely! Applied in hrev31940. Please verify so this one can be closed.

comment:5 by tqh, 10 years ago

Confirming fixed. Impressive find, did you debug or just proofread :)

comment:6 by mmlr, 10 years ago

Resolution: fixed
Status: newclosed

Thanks for the feedback, closing as fixed by hrev31940.

Note: See TracTickets for help on using tickets.