Opened 10 years ago

Closed 7 years ago

#4198 closed bug (fixed)

Preferences panel: font size menu doesn't update correctly

Reported by: humdinger Owned by: jscipione
Priority: low Milestone: R1
Component: Applications/Terminal Version: R1/pre-alpha1
Keywords: gci2011 Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev32189.

In Terminal:

  • Open preferences
  • Set font size 10
  • Close panel with OK
  • Increase size via "ALT +" (Settings|Text Size|Increase) a few times
  • Open preferences again

-> font size says "size" instead of the actual point-size

I guess this has something to do with the in/decrease text size feature.

Change History (10)

comment:1 by stpere, 10 years ago

It's pretty simple, but not sure what would be the right way to fix this. It's because your font size is then at 13 or 15 and there is no entry in the pulldown menu for those values.

I could simply make the increase and decrease font size menu entries (ALT+ +/-) to only use the values present in the pulldown menu (skip 13 and 15) to prevent this..

Or I could make the pull down menu to temporarely add the 13 and 15 values if you happen to be at that value..

Which would be prefered?

comment:2 by humdinger, 10 years ago

Thanks for taking a look at this[[BR]] IMO, what would really be needed is a text box with a small dial widget where you can increase the size arbitrarily. Same goes for the Font preferences which offers sizes 8 tru 14 plus 18. But maybe those values are intentional, because too large values would mess up the layout. OTOH, with Haiku's layout manager this shouldn't be a problem anymore and a sanity check to keep it between, say, 6 and 64 would suffice.

As someone that uses ALT+ +/- could wonder, why the font size jumps sometimes, I'd go for you suggestion:

Or I could make the pull down menu to temporarely add the 13 and 15 values if you happen to be at that value.

While you're in the Terminal prefs panel, I point out some more low prio issues. :)

  • The drop-down menus should be aligned, their lables right aligned.
  • The size drop-down menu could be as wide as in the Fonts preferences and right aligned to the text boxes of the color picker.
  • There's too much "grey space" vertically between the widgets.
  • The OK button and also the alert regarding unsaved changes when closing the prefs panel aren't needed, all settings are live.

comment:3 by stpere, 10 years ago

Owner: changed from jackburton to stpere
Status: newassigned

Regarding your last point :

  • The OK button and also the alert regarding unsaved changes when closing the prefs panel aren't needed, all settings are live.

There is something weird there.. the changes are indeed live, but aren't stored for future sessions (new terminals launched) unless you save the changes. Maybe if you refuse to save the changes, it should revert?

comment:4 by pulkomandy, 10 years ago

This is how amiga preflet worked. You can either alter the setting just for the current session or set it permanently. But Haiku is not amiga so maybe it's better to change this :)

comment:5 by humdinger, 10 years ago

I'm also for a simple solution. Always save on close (of the prefs panel).

BTW, there's also a visual glitch when changing the background colour: there's a 3px frame of the former colour.

comment:6 by stpere, 10 years ago

it's partly fixed in hrev32225.

I reworked the controls positioning, and the font dropdown menu. The Ok button, and the alert, and the 3px white margin still need to be taken care of, tho.

Also, it would be necessary to use the layout engine into that PrefWindow, since it's not font size sensitive..

comment:7 by humdinger, 10 years ago

Thanks for that! I know, I'm being pushy here, but would it be possible to have the preference panel also react to text size changes in the Terminal window? (If so, remember to also update when changing tabs. How will you handle different colors, change the pref panel accordingly or changing the tab according to the pref panel. This is quickly becoming complex... Feel free to, erm, postpone further efforts.)

comment:8 by pepol, 8 years ago

Keywords: gci2011 added

The problem was checked during GCI 2011. Works without problems on hrev43238. And after doing the steps in description, the size in Settings window actually changed to 17 in my case.

comment:9 by jscipione, 7 years ago

Owner: changed from stpere to jscipione
Status: in-progressassigned

I am going to take this ticket because I did some work on terminal font sizes last night and I have some ideas here (and code too). I don't think it's a good idea to have the font size setting in the menu affect all open Terminal windows, it should only affect the one you are on. However, you should be able to set the font size to what you want and then have that propagate to all new Terminal windows. Also the interface in Terminal settings is not great. I have some ideas on how to make it better.

comment:10 by jscipione, 7 years ago

Resolution: fixed
Status: assignedclosed

Fixed in hrev44975. Terminal now only uses font sizes from the font size list. You can set the font size directly from the Font size menu or in Settings as a submenu of the Font menu.

Note: See TracTickets for help on using tickets.