[kernel] reanming boot volume on desktop breaks everything

[diver]

If you rename Haiku icon on Desktop you will notice that you can't restart start application, Deskbar will loose it's icon and so on. Looks like a critical issue to me. hrev32785 in VirtualBox.

[Disreali]

IIRC the 'Haiku' Desktop icon is supposed to be a link to /boot, and therefore should able to be re-named without ill effect. At least, that is how BeOSr5 behaved.

[jonas.kirilla]

Wow. Kind of hard to see what just happened when you can't even 'ls' in an open Terminal.

Could this be related to the proliferation of abandoned mountpoints at /?

Disreali:

What you describe happens at the root of the filesystem. (The volumes on your desktop are not symlinks.) R5 has the boot volume mounted at /boot, and a symlink to /boot by its name. Like this: /MyVolume (symlink) -> /boot (volume actually mounted here). I believe Haiku works the same here.

Paths to files on the boot volume begin with "/boot/", as you can easily see in Tracker when opening the Info panel on files. This works the same on Haiku.

[stippi]

Without having looked at the actual code, here is what I think happens:

• The volumes usually get their mount-point named after the volume name.

• Except the boot volume, which is mounted at /boot.

• The code that renames a volume also renames the mount-point.

Can you see where it may get wrong?

[stippi]

Fixed in hrev32806 (prevent renaming /boot, ever) and hrev32807 (rename the link instead of the mount-point, for volumes that have a link in / pointing to the real mount-point).

[mmlr]

Replying to stippi:

Fixed in hrev32806 (prevent renaming /boot, ever) and hrev32807 (rename the link instead of the mount-point, for volumes that have a link in / pointing to the real mount-point).

Doesn't that prevent renaming filesystems this way now?

[stippi]

No it doesn't. The file-system is renamed first, the problem was all in the code that renamed the mount-point after the file-system (and tried to keep them in sync).

However, I talked with Ingo on the phone and he doesn't like the root-fs change. Root should still be able to rename /boot, or else it should be prevented in the VFS, via a check for a special attribute which is then attached to any entry that is forbidden to be renamed.