Opened 10 years ago

Closed 10 years ago

#4652 closed bug (fixed)

Implement origin mode in Terminal; miscellaneous positioning fixes

Reported by: joshe Owned by: anevilyak
Priority: normal Milestone: R1
Component: Applications/Terminal Version: R1/alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Attached is a patch which:

Implements origin mode.
Save origin mode and text attributes when saving the cursor.
Have RI respect the scroll region.
When erasing the screen actually erase the screen, not just the scroll region.
Implement all three variants of the EL (erase line) sequence.

Attachments (1)

term-misc-positioning.patch (13.9 KB) - added by joshe 10 years ago.
Origin mode and misc. positioning fixes; added a line which was omitted in the first version of the patch

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by joshe

Attachment: term-misc-positioning.patch added

Origin mode and misc. positioning fixes; added a line which was omitted in the first version of the patch

comment:1 Changed 10 years ago by stippi

The patch looks very clean and solid. Can you give me a hint how to apply these --git patches properly with patch? It always asks me which file to patch. (I am using patch -p0 -i your.patch). Thanks for contributing these great tickets, btw!

comment:2 in reply to:  1 Changed 10 years ago by anevilyak

Replying to stippi:

The patch looks very clean and solid. Can you give me a hint how to apply these --git patches properly with patch? It always asks me which file to patch. (I am using patch -p0 -i your.patch). Thanks for contributing these great tickets, btw!

patch -p1 will do it for those.

comment:3 Changed 10 years ago by anevilyak

Owner: changed from jackburton to anevilyak

comment:4 Changed 10 years ago by anevilyak

Status: newassigned

comment:5 Changed 10 years ago by anevilyak

Resolution: fixed
Status: assignedclosed

Applied in hrev33319. Thanks!

Note: See TracTickets for help on using tickets.