Installer doesn't show expanded files when installing to a volume with a space in it

[idefix]

When you install Haiku from the R1/Alpha1 cd to a volume with a space in it (eg. Haiku test), it won't show the file it's currently expanding from the optional packages but shows the first part of the volume name (eg. \Haiku).

This is caused by the sscanf function stopping at the first space it encounters. See source:haiku/trunk/src/apps/installer/UnzipEngine.cpp#L306.

[stippi]

It could be fixed by trying strstr() with either of the format strings to get the offset until the path within line. Want to give it a try?

[stippi]

Or BString::FindFirst() with either of the format strings.

[idefix]

Replying to stippi:

It could be fixed by trying strstr() with either of the format strings to get the offset until the path within line. Want to give it a try?

Sure, but it could take a couple of weeks.

[idefix]

Somewhat earlier than planned: installer.patch​

There are two issues with this patch:

1. If the volume name contains " -> ", Installer will still show part of the volume name.
   • I don't think this scenario is likely to happen (at least it will be a lot less likely than a volume name containing a space).

2. The names of the inflated files that Installer shows have two spaces appended to them.
   • As far as I can see, this was also the case with the previous code. And it isn't visible in Installer.

Should I try to fix any of these issues?

[idefix]

(patch) get Installer to show unzipped files when installing to volume containing space

[idefix]

Now that I think of it,

int pos = line.FindLast("  -> ");

might be replaced with

int pos = line.FindFirst("  -> ");

for better performance?

[idefix]

BTW: There's also one other sscanf function at source:haiku/trunk/src/apps/installer/UnzipEngine.cpp#L259. But I'm not sure if that one needs to be replaced too.

[idefix]

Replying to idefix:

• As far as I can see, this was also the case with the previous code. [...]

This isn't correct, those spaces wouldn't get copied by sscanf.

[stippi]

Applied in hrev36848. Thanks a lot and sorry for the delay. I've made small adjustments, but tested everything.