Opened 14 years ago
Closed 14 years ago
#5188 closed bug (fixed)
[PATCH] openfirmware: Fix TRACE_NETWORK build
| Reported by: | andreasf | Owned by: | axeld |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | System/Boot Loader | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | PowerPC |
Description
dprintf is undefined here, use printf instead.
Attachments (2)
Change History (6)
by , 14 years ago
| Attachment: | trace-network-dprintf.diff added |
|---|
comment:1 by , 14 years ago
Where is the tracing output supposed to appear? Should this be defined to "debug_printf" instead?
follow-up: 3 comment:2 by , 14 years ago
dprintf() is defined in boot/platform.h - just include it, instead of changing the debug output to printf.
debug_printf() only exists in userland, btw.
comment:3 by , 14 years ago
Replying to axeld:
dprintf() is defined in boot/platform.h - just include it, instead of changing the debug output to printf.
Whatever makes it work, patch updated. :)
There are a lot of debug printfs in the code. Should that be changed, too?
Something's odd with the line endings in many of these files btw.
Note:
See TracTickets
for help on using tickets.
patch