Opened 9 years ago

Closed 9 years ago

#5188 closed bug (fixed)

[PATCH] openfirmware: Fix TRACE_NETWORK build

Reported by: andreasf Owned by: axeld
Priority: normal Milestone: R1
Component: System/Boot Loader Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: PowerPC

Description

dprintf is undefined here, use printf instead.

Attachments (2)

trace-network-dprintf.diff (425 bytes) - added by andreasf 9 years ago.
patch
trace-network-dprintf2.diff (468 bytes) - added by andreasf 9 years ago.
updated patch

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by andreasf

Attachment: trace-network-dprintf.diff added

patch

comment:1 Changed 9 years ago by stippi

Where is the tracing output supposed to appear? Should this be defined to "debug_printf" instead?

comment:2 Changed 9 years ago by axeld

dprintf() is defined in boot/platform.h - just include it, instead of changing the debug output to printf.

debug_printf() only exists in userland, btw.

Changed 9 years ago by andreasf

Attachment: trace-network-dprintf2.diff added

updated patch

comment:3 in reply to:  2 Changed 9 years ago by andreasf

Replying to axeld:

dprintf() is defined in boot/platform.h - just include it, instead of changing the debug output to printf.

Whatever makes it work, patch updated. :)

There are a lot of debug printfs in the code. Should that be changed, too?

Something's odd with the line endings in many of these files btw.

comment:4 Changed 9 years ago by stippi

Resolution: fixed
Status: newclosed

Applied in hrev34860. Thanks!

Note: See TracTickets for help on using tickets.