Opened 10 years ago

Closed 9 years ago

#5209 closed enhancement (fixed)

Provide supported devices descriptor for usb_asix

Reported by: oruizdorantes Owned by: siarzhuk
Priority: normal Milestone: R1
Component: Drivers/USB Version: R1/alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Each time any USB device is plugged in or out usb_asix driver is sending to syslog:

usb_asix:357.34.884:init_driver::ver.0.8.3

At registering it is not providing any struct with the list of classes or devices supported, so the hooks are called for every device regardless of the type:

Driver.cpp

206:     gUSBModule->register_driver(DRIVER_NAME, 0, 0, NULL);

Couldn't we avoid this overhead by being more specific?

Attachments (1)

usb_asix.cpp (1.4 KB ) - added by oruizdorantes 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by oruizdorantes, 10 years ago

I will attach file with candidate descriptors, and reassign.

comment:2 by siarzhuk, 10 years ago

Owner: changed from oruizdorantes to siarzhuk
Status: newassigned

Anyway I'm going to refactor this driver in the nearest future to avoid virtual calls. :)

by oruizdorantes, 10 years ago

Attachment: usb_asix.cpp added

comment:3 by oruizdorantes, 10 years ago

Just if it can be useful, I had vertical editor handy in the computer.

in reply to:  3 comment:4 by siarzhuk, 10 years ago

Replying to oruizdorantes:

Just if it can be useful, I had vertical editor handy in the computer.

Thank you! And what do you meant about "vertical editor"? Sorry, I have not understand this. ;-)

comment:5 by oruizdorantes, 10 years ago

Oh, what in UltraEdit is called Column mode. Being able to select/edit/type text in multiple lines in the same column.

Regards

comment:6 by phoudoin, 9 years ago

Resolution: fixed
Status: assignedclosed

Patch applied in hrev37135. Similar changes for usb_davicom.

On a side note, the usb_serial also will need similar optimization.

Note: See TracTickets for help on using tickets.