Opened 15 years ago
Closed 14 years ago
#5209 closed enhancement (fixed)
Provide supported devices descriptor for usb_asix
Reported by: | oruizdorantes | Owned by: | siarzhuk |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Drivers/USB | Version: | R1/alpha1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
Each time any USB device is plugged in or out usb_asix driver is sending to syslog:
usb_asix:357.34.884:init_driver::ver.0.8.3
At registering it is not providing any struct with the list of classes or devices supported, so the hooks are called for every device regardless of the type:
Driver.cpp
206: gUSBModule->register_driver(DRIVER_NAME, 0, 0, NULL);
Couldn't we avoid this overhead by being more specific?
Attachments (1)
Change History (7)
comment:1 by , 15 years ago
comment:2 by , 15 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Anyway I'm going to refactor this driver in the nearest future to avoid virtual calls. :)
by , 15 years ago
Attachment: | usb_asix.cpp added |
---|
follow-up: 4 comment:3 by , 15 years ago
Just if it can be useful, I had vertical editor handy in the computer.
comment:4 by , 15 years ago
Replying to oruizdorantes:
Just if it can be useful, I had vertical editor handy in the computer.
Thank you! And what do you meant about "vertical editor"? Sorry, I have not understand this. ;-)
comment:5 by , 15 years ago
Oh, what in UltraEdit is called Column mode. Being able to select/edit/type text in multiple lines in the same column.
Regards
comment:6 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Patch applied in hrev37135. Similar changes for usb_davicom.
On a side note, the usb_serial also will need similar optimization.
I will attach file with candidate descriptors, and reassign.