Opened 10 years ago

Closed 9 years ago

#5399 closed enhancement (invalid)

Trimmed whitespace out of translations in AboutSystem

Reported by: dancxjo Owned by: pulkomandy
Priority: normal Milestone: R1
Component: Applications/AboutSystem Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

The whitespace is a hinderance to automatic translation.

Attachments (2)

aboutsystem.patch (10.3 KB ) - added by dancxjo 10 years ago.
AboutSystem-trim-whitespace-from-B_TRANSLATE.patch (5.8 KB ) - added by mmadia 9 years ago.
patched against hrev39395

Download all attachments as: .zip

Change History (13)

by dancxjo, 10 years ago

Attachment: aboutsystem.patch added

comment:1 by bonefish, 10 years ago

Owner: changed from bonefish to nobody
Status: newassigned

I don't think I understand the purpose of this patch. What do you mean by automatic translation? Like babelfish?

comment:2 by mmlr, 10 years ago

I think the point was to pull the whitespace chars out of the to be translated strings so that translators don't need to take them into account. I guess he meant things like the translation assistant site or similar?

comment:3 by dancxjo, 10 years ago

Yes. That's exactly right. "Polish" is content but "\n\nPolish\n" is content + styling/layout. The two should really be separated for effective translation.

comment:4 by humdinger, 10 years ago

Unfortunately, I saw this ticket and dancxjo's patch only after my recent commit. Should we still apply the idea behind the patch, i.e. moving the control characters out of the localizing string? It sounds right to me, OTOH, I don't know if it's that much a hassle for a translator to add a "\n" or "\t" to a translated string.

in reply to:  4 comment:5 by bonefish, 10 years ago

Owner: changed from nobody to pulkomandy
Version: R1/alpha1R1/Development

Replying to humdinger:

Unfortunately, I saw this ticket and dancxjo's patch only after my recent commit. Should we still apply the idea behind the patch, i.e. moving the control characters out of the localizing string? It sounds right to me, OTOH, I don't know if it's that much a hassle for a translator to add a "\n" or "\t" to a translated string.

I don't mind either way. It's definitely a translation issue (which I won't touch) and will probably break all existing translations (if any).

comment:6 by pulkomandy, 10 years ago

I'd like to use ICU/Locale kit directly to get the proper localized language names. No need to hand-translate them when there is already a convenient database.

And if something break translations, better fix it now than later, before there are many translations to fix.

comment:7 by pulkomandy, 10 years ago

Hello, This patch does not apply properly to the current sourcecode. Could you update it ?

by mmadia, 9 years ago

patched against hrev39395

comment:8 by mmadia, 9 years ago

Has a Patch: set

comment:9 by mmadia, 9 years ago

Here's a new patch. I wasn't sure if it'd be better to commit this now, or to hold off until after the next release.

comment:10 by siarzhuk, 9 years ago

Looks like this one can be closed as wontfix. Using control characters in translated strings is a common practice this time. Many translations for AboutSystem already performed so this patch has no sense this time, I think.

Are there any objections? What do you think, Adrien?

comment:11 by pulkomandy, 9 years ago

Resolution: invalid
Status: assignedclosed

Yes, I think this makes the code needlessly complicated, and the current status doesn't clutter the translations that much...

Note: See TracTickets for help on using tickets.