Opened 10 years ago

Closed 11 months ago

#5431 closed bug (fixed)

diff with wrong filenames

Reported by: Adek336 Owned by: nobody
Priority: normal Milestone: R1
Component: Applications/Command Line Tools Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

diff existing-file existing-file works fine
diff non-existant non-existant should write an error message for each file and return non-zero, it doesn't
diff existing-file non-existant and diff non-existant existing-file produces the error message "bad file descriptor"

hrev35505

Attachments (1)

patch (440 bytes ) - added by stpere 9 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by axeld, 10 years ago

Version: R1/alpha1R1/Development

That could be a positive error code problem.

by stpere, 9 years ago

Attachment: patch added

comment:2 by stpere, 9 years ago

Has a Patch: set

comment:3 by stpere, 9 years ago

indeed, the attached patch seems to fix it. however, I hesitate to commit it because I'm afraid that NONEXISTENT (==-2) and UNOPENED (==-1) that are internal constants in diffutils might collide with valid errno.

comment:4 by nielx, 7 years ago

Has a Patch: unset

comment:5 by scottmc, 7 years ago

If/when this is fixed it should be done in such as way that it can be upstreamed in diffutils, so we don't have to keep repatching it with new diffutil releases.

comment:6 by pulkomandy, 5 years ago

The recipe for diffutils 3.3 in haikuports still has this problem. Maybe the POSIX error mapper could be used to "fix" the error codes.

comment:7 by waddlesplash, 11 months ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.