diff with wrong filenames

[Adek336]

diff existing-file existing-file works fine
diff non-existant non-existant should write an error message for each file and return non-zero, it doesn't
diff existing-file non-existant and diff non-existant existing-file produces the error message "bad file descriptor"

hrev35505

[axeld]

That could be a positive error code problem.

[stpere]

indeed, the attached patch seems to fix it. however, I hesitate to commit it because I'm afraid that NONEXISTENT (==-2) and UNOPENED (==-1) that are internal constants in diffutils might collide with valid errno.

[scottmc]

If/when this is fixed it should be done in such as way that it can be upstreamed in diffutils, so we don't have to keep repatching it with new diffutil releases.

[pulkomandy]

The recipe for diffutils 3.3 in haikuports still has this problem. Maybe the POSIX error mapper could be used to "fix" the error codes.

[waddlesplash]

Should be fixed in ​https://github.com/haikuports/haikuports/commit/008ed157f02a304d3b2b4ff4ad8693d9faea5806.

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone