Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#5457 closed enhancement (fixed)

[patch] Add wifi drivers & firmwares to default Haiku image

Reported by: mmadia Owned by: bonefish
Priority: normal Milestone: R1
Component: Build System Version: R1/Development
Keywords: Cc:
Blocked By: #5454, #5455 Blocking:
Has a Patch: no Platform: All

Description (last modified by mmadia)

Adds wifi drivers, firmwares, and install-wifi-firmwares.sh to default image. Another patch for AboutSystem is also attached, as its preferred that these be committed together or in succession.

Attachments (2)

5457-AboutSystem-WifiFirmwareCopyrights.patch (2.8 KB ) - added by mmadia 10 years ago.
ready for review
5457-AddDriversFirmwareAndScriptToDefaultImage.patch (5.1 KB ) - added by mmadia 10 years ago.
updated per comment 6

Download all attachments as: .zip

Change History (11)

comment:1 by mmadia, 10 years ago

Blocked By: 5455 removed

(In #5455) hmmm... seems this may need to be altered a bit to account for firmware archives that are zips.

by mmadia, 10 years ago

ready for review

comment:2 by mmadia, 10 years ago

Blocked By: 5455 added
Description: modified (diff)

Upon discussion with Colin, the notion of the settings file is no longer needed and his handled directly in the driver.

Pending any requested changes, this ticket, #5454, #5455, & #5456 can be committed.

comment:3 by bonefish, 10 years ago

I don't like this solution. The Jamfiles should never add anything to the images. The driver itself should definitely not depend on any image target.

Just declaring the firmware packages and archives in the Jamfiles would be fine, e.g.:

HAIKU_WIFI_FIRMWARE_PACKAGE on ralinkwifi = RT61_Firmware_V1.2 ;
HAIKU_WIFI_FIRMWARE_ARCHIVE on ralinkwifi = RT61_Firmware_V1.2.zip ;

Then in HaikuImage loop over the drivers and add their firmware.

in reply to:  3 ; comment:4 by mmadia, 10 years ago

Replying to bonefish:

Just declaring the firmware packages and archives in the Jamfiles would be fine, e.g.:

HAIKU_WIFI_FIRMWARE_PACKAGE on ralinkwifi = RT61_Firmware_V1.2 ;
HAIKU_WIFI_FIRMWARE_ARCHIVE on ralinkwifi = RT61_Firmware_V1.2.zip ;

Then in HaikuImage loop over the drivers and add their firmware.

That is much cleaner. Thanks. I also added another variable HAIKU_WIFI_FIRMWARE_DRIVERS, to keep track of which wifi drivers need firmware.

in reply to:  4 ; comment:5 by bonefish, 10 years ago

Replying to mmadia:

That is much cleaner. Thanks. I also added another variable HAIKU_WIFI_FIRMWARE_DRIVERS, to keep track of which wifi drivers need firmware.

Either that or simply iterate through all of them and skip the ones that don't have HAIKU_WIFI_FIRMWARE_PACKAGE set.

in reply to:  5 ; comment:6 by bonefish, 10 years ago

Replying to bonefish:

Replying to mmadia:

That is much cleaner. Thanks. I also added another variable HAIKU_WIFI_FIRMWARE_DRIVERS, to keep track of which wifi drivers need firmware.

Either that or simply iterate through all of them and skip the ones that don't have HAIKU_WIFI_FIRMWARE_PACKAGE set.

Oh, I totally missed that you already added the patch. Come to think of it, the HAIKU_WIFI_FIRMWARE_DRIVERS approach has the drawback that not including such a driver in the image will be unnecessarily complicated, since the firmware would still be added, unless one also comments out the line in the Jamfile.

by mmadia, 10 years ago

updated per comment 6

in reply to:  6 comment:7 by mmadia, 10 years ago

Replying to bonefish:

Oh, I totally missed that you already added the patch. Come to think of it, the HAIKU_WIFI_FIRMWARE_DRIVERS approach has the drawback that not including such a driver in the image will be unnecessarily complicated, since the firmware would still be added, unless one also comments out the line in the Jamfile.

Ahh, good point. The updated patch is attached. Though I needed to check $(archive), as at least one of the Marvell drivers do not set $(package).

comment:8 by bonefish, 10 years ago

Resolution: fixed
Status: newclosed

Thanks! Applied in hrev35687.

comment:9 by colin, 10 years ago

5457-AboutSystem-WifiFirmwareCopyrights.patch applied in hrev35691 with minor modifications by me. Thank you!

Note: See TracTickets for help on using tickets.