[patch] Add wifi drivers & firmwares to default Haiku image

[mmadia]

Adds wifi drivers, firmwares, and install-wifi-firmwares.sh to default image. Another patch for AboutSystem is also attached, as its preferred that these be committed together or in succession.

[mmadia]

(In #5455) hmmm... seems this may need to be altered a bit to account for firmware archives that are zips.

[mmadia]

ready for review

[mmadia]

Upon discussion with Colin, the notion of the settings file is no longer needed and his handled directly in the driver.

Pending any requested changes, this ticket, #5454, #5455, & #5456 can be committed.

[bonefish]

I don't like this solution. The Jamfiles should never add anything to the images. The driver itself should definitely not depend on any image target.

Just declaring the firmware packages and archives in the Jamfiles would be fine, e.g.:

HAIKU_WIFI_FIRMWARE_PACKAGE on ralinkwifi = RT61_Firmware_V1.2 ;
HAIKU_WIFI_FIRMWARE_ARCHIVE on ralinkwifi = RT61_Firmware_V1.2.zip ;

Then in HaikuImage loop over the drivers and add their firmware.

[mmadia]

Replying to bonefish:

Just declaring the firmware packages and archives in the Jamfiles would be fine, e.g.:

HAIKU_WIFI_FIRMWARE_PACKAGE on ralinkwifi = RT61_Firmware_V1.2 ;
HAIKU_WIFI_FIRMWARE_ARCHIVE on ralinkwifi = RT61_Firmware_V1.2.zip ;

Then in HaikuImage loop over the drivers and add their firmware.

That is much cleaner. Thanks. I also added another variable HAIKU_WIFI_FIRMWARE_DRIVERS, to keep track of which wifi drivers need firmware.

[bonefish]

Replying to mmadia:

That is much cleaner. Thanks. I also added another variable HAIKU_WIFI_FIRMWARE_DRIVERS, to keep track of which wifi drivers need firmware.

Either that or simply iterate through all of them and skip the ones that don't have HAIKU_WIFI_FIRMWARE_PACKAGE set.

[bonefish]

Replying to bonefish:

Replying to mmadia:

That is much cleaner. Thanks. I also added another variable HAIKU_WIFI_FIRMWARE_DRIVERS, to keep track of which wifi drivers need firmware.

Either that or simply iterate through all of them and skip the ones that don't have HAIKU_WIFI_FIRMWARE_PACKAGE set.

Oh, I totally missed that you already added the patch. Come to think of it, the HAIKU_WIFI_FIRMWARE_DRIVERS approach has the drawback that not including such a driver in the image will be unnecessarily complicated, since the firmware would still be added, unless one also comments out the line in the Jamfile.

[mmadia]

updated per comment 6

[mmadia]

Replying to bonefish:

Oh, I totally missed that you already added the patch. Come to think of it, the HAIKU_WIFI_FIRMWARE_DRIVERS approach has the drawback that not including such a driver in the image will be unnecessarily complicated, since the firmware would still be added, unless one also comments out the line in the Jamfile.

Ahh, good point. The updated patch is attached. Though I needed to check $(archive), as at least one of the Marvell drivers do not set $(package).

[bonefish]

Thanks! Applied in hrev35687.

[colin]

5457-AboutSystem-WifiFirmwareCopyrights.patch applied in hrev35691 with minor modifications by me. Thank you!