Looks like BMenus dont tint their colors

[mikael.konradson@…]

1. Change colors using the menu preflet. (Choose a very dark color).
2. Restart tracker
3. you will now see the 3d effect colors with their original colors, a much

better (the correct) way would be to use tint_color /Darken/Lighten here. (LeftTop -RightTop/LeftBottom) should be using tint_color(HighColor(), B_LIGHTEN_*_COLOR). And the opposite coordinates should use a Darer version.

P.S I dont have the source here, maybe its already tinted, but its a bug though D.S /Mikael Konradsson

[mikael.konradson@…]

Rev: 17244. Sorry forgot that.

[jackburton]

Problem is that colors returned by ui_color() are fixed at the moment. Once this is fixed/changed, this bug should go away automatically.

[jackburton]

I had a look at this bug again, and looks like I was wrong. The problem is that the menu preflet uses set_menu_info() to set the menu colors, but that function only updates the menu_info struct, and not the color returned by ui_color(B_MENU_BACKGROUND_COLOR). And, since we use either ui_color(B_MENU_BACKGROUND_COLOR) or the background_color member of menu_info to get the menu background color, we should make sure that DesktopSettingsPrivate::SetMenuInfo() also updates the ui_color.

[jackburton]

Fixed in hrev23070.