Opened 10 years ago

Closed 10 years ago

#5560 closed enhancement (fixed)

[patch] MandatoryPackages

Reported by: mmadia Owned by: bonefish
Priority: normal Milestone: R1
Component: Build System Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Seeing as this is a non-trivial patch, I see the value in pre-commit review. This is a slightly revised patch from the haiku-development/HaikuPorts-dev sed thread

  • Introduced "MandatoryPackages", which is added to all default images
  • Renamed "BasicCommandLinesTools" to "Sed"
  • Removed isCDPackage's parameter from "Sed"s InstallOptionalHaikuImagePackage
  • Currently, "MandatoryPackages" only dependency is "Sed"

Attachments (1)

5560-MandatoryPackages.diff (4.0 KB ) - added by mmadia 10 years ago.

Download all attachments as: .zip

Change History (4)

by mmadia, 10 years ago

Attachment: 5560-MandatoryPackages.diff added

comment:1 by mmadia, 10 years ago

To note, this has been tested with various images: haiku-image, haiku-vmware-image, haiku-cd, and each of the @nightly-* profiles.

comment:2 by bonefish, 10 years ago

As written on the list AddOptionalHaikuImagePackages should not be invoked in HaikuImage, which also makes the second inclusion of OptionalPackageDependencies superfluous.

comment:3 by mmadia, 10 years ago

Resolution: fixed
Status: newclosed

Applied in hrev35829 with your suggestions included.

Note: See TracTickets for help on using tickets.