Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#5616 closed bug (fixed)

[TRAC] prefs box overlaps long lines in message text

Reported by: jstressman Owned by: haiku-web
Priority: normal Milestone:
Component: Website/Trac Version:
Keywords: Cc: jstressman@…, mdisreali@…
Blocked By: Blocking:
Platform: All

Description

On trac messages, if you have a very long line of text, the floating preferences box on the right side overlaps the message text due to the use of a 'pre' tag for the message text causing the message text not to wrap.

Adding the following line to http://dev.haiku-os.org/chrome/common/css/diff.css in the rule "#overview dd.message pre" will fix the problem in modern browsers:

white-space: pre-wrap;

This allows the diff.css file to still validate as valid CSS 2.1 with the W3 CSS validator.

(I can send this upstream to the official Trac people if need be?)

Attachments (2)

example-commit.png (96.3 KB ) - added by mmadia 14 years ago.
diff.css.patch (499 bytes ) - added by Disreali 14 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 by jstressman, 14 years ago

Cc: jstressman@… added

I wanted to add that while this allows the 'pre' wrapped text to wrap on the page, it doesn't affect the text itself, so copy/pastes of the message itself will still retain the original format, line breaks, etc. So it shouldn't have any negative effect on code snippets etc.

comment:2 by nielx, 14 years ago

Do you have an example ticket?

by mmadia, 14 years ago

Attachment: example-commit.png added

comment:3 by Disreali, 14 years ago

Cc: mdisreali@… added

comment:4 by Disreali, 14 years ago

Summary: message prefs box overlaps long lines in message text[TRAC] prefs box overlaps long lines in message text

This is still an issue when reading changeset pages. If I understood the description correctly, the attached patch should help.

by Disreali, 14 years ago

Attachment: diff.css.patch added

comment:5 by Disreali, 14 years ago

patch: 01

comment:6 by jstressman, 14 years ago

This is still present, and the patch it still the same. I've just tested both again.

Do I need to send this upstream? (or has it been already?)

in reply to:  6 comment:7 by nielx, 14 years ago

Replying to jstressman:

This is still present, and the patch it still the same. I've just tested both again.

Do I need to send this upstream? (or has it been already?)

Yes, please push it upstream. A ticket search did not yield any results, but please verify (I searched for all components in version control wit the description search word 'wrap').

comment:8 by Disreali, 13 years ago

Was the patch ever upstreamed?

comment:9 by zooey, 13 years ago

Resolution: fixed
Status: newclosed

I have no idea if the patch was ever upstreamed, but I have applied it to our own Trac buildservice project and -customizations repo. The patch indeed fixes the wrapping of messages - thanks!

comment:10 by Disreali, 13 years ago

Thank you. It works well in Web+ but not Bezilla. I think our Bezilla is just to old at this point.

[edited to fix typo]

Last edited 13 years ago by Disreali (previous) (diff)
Note: See TracTickets for help on using tickets.