Opened 10 years ago

Closed 10 years ago

#5619 closed enhancement (fixed)

[PATCH] Add support for setting local domain to network prefs + dhcp client

Reported by: vegardw Owned by: stippi
Priority: normal Milestone: R1
Component: Preferences/Network Version: R1/Development
Keywords: dns dhcp Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

The following patch adds support for setting the the local domain in the network settings, and sets the domain if received by DHCP.

Attachments (1)

network.diff (5.8 KB ) - added by vegardw 10 years ago.
style fixup, take 2

Download all attachments as: .zip

Change History (4)

comment:1 by vegardw, 10 years ago

Summary: [Patch] Add support for local domain to network prefs + dhcp client[PATCH] Add support for setting local domain to network prefs + dhcp client

comment:2 by stippi, 10 years ago

Owner: changed from axeld to stippi
Status: newin-progress

Thanks! Functionally, the patch looks fine. I am just uncertain with regards to overwriting resolv.conf, but that's just the same as the rest of the preflet. Before I can apply your patch, you need to fix some style issues. Mostly it seems your editor has the wrong tab settings. Just look at the patch here in Trac, and you can easily spot the wrong indentation. We use four spaces indentation per tab, and use tabs exclusively, no spaces. The other problem is with regards to parenthesis. We use this style:

if (condition) {
}

I.e. space between if and ( and parenthesis on the same line. If you could fix those, I'll be happy to apply your work! Thanks again!

by vegardw, 10 years ago

Attachment: network.diff added

style fixup, take 2

comment:3 by stippi, 10 years ago

Resolution: fixed
Status: in-progressclosed

Thanks for the updated patch! Applied in hrev35938.

Note: See TracTickets for help on using tickets.