Opened 15 years ago
Closed 15 years ago
#5698 closed bug (fixed)
[patch] ReiserFS label support
Reported by: | wtachi | Owned by: | bonefish |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | File Systems/ReiserFS | Version: | R1/Development |
Keywords: | gsoc2010 | Cc: | |
Blocked By: | Blocking: | ||
Platform: | All |
Description
This patch adds support for labels (volume names) on ReiserFS filesystems.
Attachments (1)
Change History (7)
comment:1 by , 15 years ago
comment:2 by , 15 years ago
Patch changed to use B_ENTRY_NOT_FOUND or B_OK. (Is B_ENTRY_NOT_FOUND okay? It's the best thing I could find...)
comment:3 by , 15 years ago
Component: | File Systems → File Systems/ReiserFS |
---|
Updating ticket for new component File Systems/ReiserFS.
comment:4 by , 15 years ago
Keywords: | gsoc2010 added |
---|
comment:5 by , 15 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Thanks for the patch! It looks good with the exception of the strlcpy() use in SuperBlock::GetLabel(). The second parameter must be a null-terminated string, which is not guaranteed to be the case here.
by , 15 years ago
Attachment: | reiserfs-label.patch added |
---|
Whoops, I missed that last strlen(). Patch updated to not use strlcpy().
comment:6 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Thanks! Committed in hrev36132.
Note:
See TracTickets
for help on using tickets.
GetLabel could return something like a status_t instead of an int.