[ShowImage] right click open image, first option is always selected

[diver]

Open any image in ShowImage.
Right click it.
Notice that 1st option is selected.
Additionally it would be nice to make this menu sticky.
Tested with hrev36474 in VirtualBox 3.0.12

[leavengood]

Fixed in hrev36799. The menu is now sticky and offset so that the first option is not automatically selected.

[diver]

5 pixels looks like a bit too much, how about 2?

[leavengood]

Replying to diver:

5 pixels looks like a bit too much, how about 2?

Sure that works fine. Changed in hrev36806.

[diver]

Should this be reverted after hrev40132 / hrev40142?

[diver]

Also hrev36762 is another candidate for reverting.

[leavengood]

Replying to diver:

Should this be reverted after hrev40132 / hrev40142?

Yeah I think so and did so in hrev40179. As for the Tracker change, I don't know since I didn't do it but it could probably be reverted too since it is essentially doing the same thing.

[diver]

Maybe we need to add stippi to Cc?

[leavengood]

Hey Stephan,

Diver brought up this old ticket due to my recent menu changes that make things like this unnecessary. He also pointed out a change you made to Tracker for a similar reason: https://dev.haiku-os.org/changeset/36762

We figure that can probably be reverted now too, but I figured I would ask. I do wonder about the deletion of code on line 2484 and if that would need to be brought back if that change was reverted.

[stippi]

Well, it looks a bit like I only meant to remove the first two lines, not the third one as well. :-O If you look at the changeset in Trac, just widen the context lines to 12 lines or such and you see why I removed those lines (and why the third was probably a hasty mistake).

[stippi]

Ah, no. Actually I probably thought that CommitActivePose() was called twice in that function by mistake. So everything is fine, I just removed duplicated code that might have been a copy&paste leftover.

[diver]

AFAICS hrev36762 is still not reverted. I'll reopen this ticket until this is fixed for now if you don't mind.

[diver]

ping.

[leavengood]

I finally reverted hrev36762 in hrev42017 so this ticket can finally be closed again. Thanks for the reminder diver!