Opened 10 years ago

Closed 8 years ago

#5809 closed bug (fixed)

[ShowImage] right click open image, first option is always selected

Reported by: diver Owned by: leavengood
Priority: normal Milestone: R1
Component: Applications/ShowImage Version: R1/Development
Keywords: Cc: superstippi@…
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Open any image in ShowImage.
Right click it.
Notice that 1st option is selected.
Additionally it would be nice to make this menu sticky.
Tested with hrev36474 in VirtualBox 3.0.12

Change History (13)

comment:1 by leavengood, 10 years ago

Resolution: fixed
Status: newclosed

Fixed in hrev36799. The menu is now sticky and offset so that the first option is not automatically selected.

comment:2 by diver, 10 years ago

5 pixels looks like a bit too much, how about 2?

in reply to:  2 comment:3 by leavengood, 10 years ago

Replying to diver:

5 pixels looks like a bit too much, how about 2?

Sure that works fine. Changed in hrev36806.

comment:4 by diver, 9 years ago

Should this be reverted after hrev40132 / hrev40142?

comment:5 by diver, 9 years ago

Also hrev36762 is another candidate for reverting.

in reply to:  4 comment:6 by leavengood, 9 years ago

Replying to diver:

Should this be reverted after hrev40132 / hrev40142?

Yeah I think so and did so in hrev40179. As for the Tracker change, I don't know since I didn't do it but it could probably be reverted too since it is essentially doing the same thing.

comment:7 by diver, 9 years ago

Maybe we need to add stippi to Cc?

comment:8 by leavengood, 9 years ago

Cc: superstippi@… added

Hey Stephan,

Diver brought up this old ticket due to my recent menu changes that make things like this unnecessary. He also pointed out a change you made to Tracker for a similar reason: https://dev.haiku-os.org/changeset/36762

We figure that can probably be reverted now too, but I figured I would ask. I do wonder about the deletion of code on line 2484 and if that would need to be brought back if that change was reverted.

comment:9 by stippi, 9 years ago

Well, it looks a bit like I only meant to remove the first two lines, not the third one as well. :-O If you look at the changeset in Trac, just widen the context lines to 12 lines or such and you see why I removed those lines (and why the third was probably a hasty mistake).

Last edited 9 years ago by stippi (previous) (diff)

comment:10 by stippi, 9 years ago

Ah, no. Actually I probably thought that CommitActivePose() was called twice in that function by mistake. So everything is fine, I just removed duplicated code that might have been a copy&paste leftover.

comment:11 by diver, 9 years ago

Resolution: fixed
Status: closedreopened

AFAICS hrev36762 is still not reverted. I'll reopen this ticket until this is fixed for now if you don't mind.

comment:12 by diver, 8 years ago

ping.

comment:13 by leavengood, 8 years ago

Resolution: fixed
Status: reopenedclosed

I finally reverted hrev36762 in hrev42017 so this ticket can finally be closed again. Thanks for the reminder diver!

Note: See TracTickets for help on using tickets.