Opened 9 years ago

Closed 9 years ago

#5835 closed bug (fixed)

Context menus broken

Reported by: axeld Owned by: anevilyak
Priority: normal Milestone: R1/alpha2
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

ProcessController's and the mail context menu via the Deskbar don't work right anymore: you cannot choose an item anymore with the button held, and invoking it when releasing the button.

Using hrev36514.

Attachments (1)

patch.diff (405 bytes) - added by jackburton 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by anevilyak

Will hopefully have time to look into it in the next few days....BMenu's horrible API makes handling all the cases properly quite painful though :/

comment:2 in reply to:  1 ; Changed 9 years ago by jackburton

Replying to anevilyak:

Will hopefully have time to look into it in the next few days....BMenu's horrible API makes handling all the cases properly quite painful though :/

I think hrev36453 is the culprit. I remembered it wrongly: it wasn't for BMenuFields but for regular context menus.

comment:3 in reply to:  2 ; Changed 9 years ago by anevilyak

Replying to jackburton:

I think hrev36453 is the culprit. I remembered it wrongly: it wasn't for BMenuFields but for regular context menus.

Any thoughts on how best to remedy that? hrev36453 was specifically trying to fix a problem with context menus, namely that e.g. the ones on the terminal tabs always invoke the close item immediately, even though they're using click to open.

comment:4 in reply to:  3 Changed 9 years ago by jackburton

Replying to anevilyak:

Any thoughts on how best to remedy that? hrev36453 was specifically trying to fix a problem with context menus, namely that e.g. the ones on the terminal tabs always invoke the close item immediately, even though they're using click to open.

I'm not able to commit right now, but you might want to try the attached patch, which basically reverts hrev24863.

Changed 9 years ago by jackburton

Attachment: patch.diff added

comment:5 Changed 9 years ago by anevilyak

No difference with that change here at least.

comment:6 Changed 9 years ago by axeld

This should only improve the Terminal case AFAICT when reverting hrev36453, right?

comment:7 in reply to:  6 Changed 9 years ago by jackburton

Replying to axeld:

This should only improve the Terminal case AFAICT when reverting hrev36453, right?

Uh... right. Sorry, I forgot I had also reverted hrev36453 (p.s. sorry Rene :-) )

comment:8 Changed 9 years ago by anevilyak

Status: newin-progress

That behaves as expected for me in both cases at least, can you try with hrev36575 Axel?

comment:9 Changed 9 years ago by axeld

Resolution: fixed
Status: in-progressclosed

Thanks, works great!

Note: See TracTickets for help on using tickets.