Context menus broken

[axeld]

ProcessController's and the mail context menu via the Deskbar don't work right anymore: you cannot choose an item anymore with the button held, and invoking it when releasing the button.

Using hrev36514.

[anevilyak]

Will hopefully have time to look into it in the next few days....BMenu's horrible API makes handling all the cases properly quite painful though :/

[jackburton]

Replying to anevilyak:

Will hopefully have time to look into it in the next few days....BMenu's horrible API makes handling all the cases properly quite painful though :/

I think hrev36453 is the culprit. I remembered it wrongly: it wasn't for BMenuFields but for regular context menus.

[anevilyak]

Replying to jackburton:

I think hrev36453 is the culprit. I remembered it wrongly: it wasn't for BMenuFields but for regular context menus.

Any thoughts on how best to remedy that? hrev36453 was specifically trying to fix a problem with context menus, namely that e.g. the ones on the terminal tabs always invoke the close item immediately, even though they're using click to open.

[jackburton]

Replying to anevilyak:

Any thoughts on how best to remedy that? hrev36453 was specifically trying to fix a problem with context menus, namely that e.g. the ones on the terminal tabs always invoke the close item immediately, even though they're using click to open.

I'm not able to commit right now, but you might want to try the attached patch, which basically reverts hrev24863.

[anevilyak]

No difference with that change here at least.

[axeld]

This should only improve the Terminal case AFAICT when reverting hrev36453, right?

[jackburton]

Replying to axeld:

This should only improve the Terminal case AFAICT when reverting hrev36453, right?

Uh... right. Sorry, I forgot I had also reverted hrev36453 (p.s. sorry Rene :-) )

[anevilyak]

That behaves as expected for me in both cases at least, can you try with hrev36575 Axel?

[axeld]

Thanks, works great!