Opened 9 years ago

Closed 9 years ago

#5905 closed enhancement (fixed)

Installedpackages localization patch

Reported by: Karvjorm Owned by: stippi
Priority: normal Milestone: R1
Component: Applications Version: R1/alpha1
Keywords: installedpackages localization patch Cc: Karvjorm
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Here is localization of installedpackages

Attachments (1)

installedpackagesLocalization.patch (7.2 KB) - added by Karvjorm 9 years ago.
Fixed installedpackagesLocalization patch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by stippi

The patch looks mostly good, thanks, but I would remove the translation of debug messages that are printed in the Terminal only. Some printf()s are probably ok to be translated, but most of them seem to be debug messages only.

comment:2 Changed 9 years ago by stippi

Karvjorm, do you plan to revert the translation of the debug messages?

comment:3 Changed 9 years ago by Karvjorm

Yes, I can do it, but it can take some time.

Changed 9 years ago by Karvjorm

Fixed installedpackagesLocalization patch

comment:4 Changed 9 years ago by Karvjorm

I have updated now this patch.

comment:5 Changed 9 years ago by stippi

Owner: changed from nobody to stippi
Status: newin-progress

Thanks. The Jamfile is missing the DoCatalogs rule invokation, but I'll add that for you. The patch is just fine otherwise.

comment:6 Changed 9 years ago by stippi

Resolution: fixed
Status: in-progressclosed

Applied with heavy changes in hrev36661. You did not test-run your patch! :-) See commit message.

Note: See TracTickets for help on using tickets.