Opened 9 years ago

Closed 9 years ago

#6089 closed bug (fixed)

Updated localization patch for Print Server

Reported by: Karvjorm Owned by: laplace
Priority: normal Milestone: R1
Component: Servers/print_server Version: R1/alpha2
Keywords: Print server localization update Cc: Karvjorm
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

When I checked one available translation for Print Server, I noticed that "Letter" was translated as a postal term and "Legal" as a juridical one (it is already fixed). I have updated localisations strings with comments.

Attachments (1)

print_serverLocalizationUpdate.patch (8.0 KB) - added by Karvjorm 9 years ago.
An updated print_serverLocalizationUpdate patch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by Karvjorm

Has a Patch: set

comment:3 Changed 9 years ago by laplace

Status: newin-progress

comment:4 Changed 9 years ago by laplace

Thank you, I will apply the patch soon.

comment:5 Changed 9 years ago by laplace

I have now looked at the patch more closely and there are some issues:

1.) I am not sure if scripting "usage" text should be translated.
2.) In ConfigWindow.cpp you changed B_TRANSLATE_MARK to B_TRANSLATE_COMMENT, but B_TRANSLATE_MARK_COMMENT would be correct.
3.) In the "about" text the copyright year and the authors should not be translated. They may change frequently and should not force a translation update.
4.) When you use sprintf(str, ...) str must not be NULL.
There is also no space between sprintf( and str.

Could you provide a new patch that fixes 2-4?

comment:6 in reply to:  5 Changed 9 years ago by Karvjorm

Replying to laplace:

I have now looked at the patch more closely and there are some issues:

1.) I am not sure if scripting "usage" text should be translated.
2.) In ConfigWindow.cpp you changed B_TRANSLATE_MARK to B_TRANSLATE_COMMENT, but B_TRANSLATE_MARK_COMMENT would be correct.
3.) In the "about" text the copyright year and the authors should not be translated. They may change frequently and should not force a translation update.
4.) When you use sprintf(str, ...) str must not be NULL.
There is also no space between sprintf( and str.

Could you provide a new patch that fixes 2-4?

OK, I'll do it soon.

Changed 9 years ago by Karvjorm

An updated print_serverLocalizationUpdate patch

comment:7 Changed 9 years ago by laplace

Resolution: fixed
Status: in-progressclosed

Applied in hrev36964 (slightly modified). Thank you!

Note: See TracTickets for help on using tickets.