Opened 9 years ago

Closed 9 years ago

#6123 closed enhancement (fixed)

[PATCH] OpenFirmware: Assure machine is initialized to unknown

Reported by: andreasf Owned by: andreasf
Priority: low Milestone: R1
Component: System/Boot Loader Version: R1/Development
Keywords: QEMU OpenBIOS Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: PowerPC

Description

QEMU's default ppc machine g3beige does not have a device_type property. This will lead to the function returning right away.

Whether that is an OpenBIOS bug or not, let's play fool-safe and move the variable initialization to the top.

Priority: low

Note: The mac99 machine does have the device_type property as expected.

Attachments (1)

0001-Initialize-machine-to-unknown-before-return.patch (994 bytes) - added by andreasf 9 years ago.
proposed patch

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by andreasf

proposed patch

comment:1 Changed 9 years ago by andreasf

Has a Patch: set

comment:2 Changed 9 years ago by andreasf

Owner: changed from axeld to andreasf
Priority: normallow
Status: newin-progress

comment:3 Changed 9 years ago by andreasf

Resolution: fixed
Status: in-progressclosed

Applied in hrev37280.

Note: See TracTickets for help on using tickets.