[Tracker] doesn't let you to rename system folders

[diver]

Tracker doesn't let you to rename system folders.

[axeld]

You mean beyond the alert that comes up and asks you to press shift??

[diver]

Exactly!

[jackburton]

AFAIR in BeOS when a modal window shows up, it doesn't "steal" the focus from the current active window. In haiku, it does. What does this mean ? That when the OverrideAlert quits, the tracker window receives the activation message, thus calling WindowActivated() on the TextWidget, which never enters editing mode.

[nielx]

Does this mean that this bug is actually an Interface Kit bug?

[jackburton]

I added a debugger call in TextWidget::StopEdit() and this is the backtrace when I try to rename a system folder (attached).

So looks like I am right, on beos the window doesn't lose the active status when there's a BAlert originating from it.

[jackburton]

backtrace to see the code path

[jackburton]

Fixed in hrev23062, but needs review.

[jackburton]

BTW I should explain what happens here:

BTextWidget::StartEdit() is called, then the OverrideAlert shows up. The B_WINDOW_ACTIVATED message is sent to the ContainerWindow which contains the BTextWidget with "activated" = false. But this message is not handled, since the OverrideAlert is synchronous, and the ContainerWindow is locked. As soon as the user dismiss the alert, the ContainerWindow unlocks and the messages are handled. But that message is already old, it should've been handled before. That's why the BAlert uses UpdateIfNeeded() in a loop. Testing on beos is needed to check which messages are handled.

[axeld]

Revised in hrev23196; DispatchMessage() now always only takes the last B_WINDOW_ACTIVATED message into account, reverted hrev23062.