Opened 9 years ago

Closed 9 years ago

#6251 closed bug (fixed)

Wrong comparison in mp3_decoder

Reported by: kaliber Owned by: dlmcpaul
Priority: normal Milestone: R1
Component: Kits/Media Kit Version: R1/Development
Keywords: clang Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

src/add-ons/media/plugins/mp3_decoder/mp3DecoderPlugin.cpp:364:55: warning: self-comparison always evaluates to false
        if (version_index1 != version_index2 || layer_index1 != layer_index1)
                                                             ^

src/add-ons/media/plugins/mp3_reader/MP3ReaderPlugin.cpp:1102:55: warning: self-comparison always evaluates to false
        if (version_index1 != version_index2 || layer_index1 != layer_index1)
                                                             ^

Change History (5)

comment:1 by anevilyak, 9 years ago

Owner: changed from axeld to dlmcpaul
Status: newassigned

comment:2 by dlmcpaul, 9 years ago

Resolution: fixed
Status: assignedclosed

fixed in hrev37362

comment:3 by kaliber, 9 years ago

Resolution: fixed
Status: closedreopened

There were two places (at line 364 and 1102), you have fixed only the first one.

comment:4 by dlmcpaul, 9 years ago

Ok fixed the other file as well.

comment:5 by anevilyak, 9 years ago

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.