Opened 9 years ago

Closed 9 years ago

#6253 closed bug (fixed)

Typo in src/kits/tracker/AttributeStream.h

Reported by: kaliber Owned by: anevilyak
Priority: normal Milestone: R1
Component: Kits/libtracker.so Version: R1/Development
Keywords: clang Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Looks like it should be a comparison instead of assignment.

src/kits/tracker/AttributeStream.h:399:46: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
        if (strcmp(fAttr.Name(), name) == 0 && type = fAttr.Type())
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
src/kits/tracker/AttributeStream.h:399:46: note: use '==' to turn this assignment into an equality comparison
        if (strcmp(fAttr.Name(), name) == 0 && type = fAttr.Type())
                                                    ^
                                                    ==
src/kits/tracker/AttributeStream.h:399:46: note: place parentheses around the assignment to silence this warning
        if (strcmp(fAttr.Name(), name) == 0 && type = fAttr.Type())
                                                    ^
            (                                                     )

Change History (3)

comment:1 by anevilyak, 9 years ago

Component: Kits/Interface KitKits/libtracker.so
Owner: changed from axeld to anevilyak

comment:2 by anevilyak, 9 years ago

Status: newin-progress

comment:3 by anevilyak, 9 years ago

Resolution: fixed
Status: in-progressclosed

Fixed in hrev37358.

Note: See TracTickets for help on using tickets.