Opened 9 years ago

Closed 8 years ago

#6275 closed enhancement (fixed)

unused code in src/system/kernel/elf.cpp

Reported by: lucian Owned by: axeld
Priority: normal Milestone: R1
Component: System/Kernel Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Found some code that seems to be left over from a copy-pasting.

Attachments (1)

elf-small-dead-code-removal.patch (977 bytes) - added by lucian 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by lucian

comment:1 Changed 9 years ago by lucian

Has a Patch: set

comment:2 Changed 9 years ago by bonefish

That code was added in hrev16878, supposedly addressing a TODO about segment order. Fortunately the ticket is already assigned to the man in question. :-)

comment:3 Changed 9 years ago by axeld

Indeed, it looks like there is something missing in this commit. So in any case, I would rather complete it, than remove it altogether :-)

comment:4 Changed 8 years ago by axeld

Resolution: fixed
Status: newclosed

Sorry for the long delay. I've removed the code now, as it seems to work fine without it, anyway :-) Thanks for your patch!

Note: See TracTickets for help on using tickets.