Jamfiles shouldn't use -Wall

[kaliber]

BuildSetup defines default warning flags, but some of Jamfiles adds its own. If -Wall is added then it could re-enable some warnings. For example:

BuildSetup defines:

HAIKU_WARNING_CCFLAGS = -Wall -Wno-trigraphs ...

src/add-ons/kernel/drivers/network/etherpci/Jamfile defines:

SubDirCcFlags -Wall ;

and the final CFLAGS are:

-Wall -Wno-trigraphs ... -Wall

Since -Wall implies -Wtrigraphs, the final result may be different then expected.

[kaliber]

Ping.

[stippi]

Patch looks fine to me. Will see if it still applies cleanly.

[bonefish]

In the cases where -Wall is removed for the haiku target, -Wno-multichar should be removed as well, as it is in HAIKU_WARNING_{CC,C++}FLAGS, too.

Since the occurrence in src/add-ons/kernel/file_systems/bfs/Jamfile is probably the one that was copied into all the other BFS and file system related Jamfiles, it would be interesting, if Axel had a particular reason to do that (e.g. to explicitly re-enable the otherwise disabled -Wall warnings) or if that is only legacy inherited from ancient times.

[axeld]

If memory serves well (although it almost never does ;-)), this is indeed ancient - a long time back we did not use -Wall globally.

[stippi]

Patch applied hrev39314 (while additionally removing -Wno-multichar for most files in this patch). Thanks!