Opened 14 years ago

Last modified 13 years ago

#6333 closed enhancement

Jamfiles shouldn't use -Wall — at Version 4

Reported by: kaliber Owned by: stippi
Priority: normal Milestone: R1
Component: Build System Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description (last modified by stippi)

BuildSetup defines default warning flags, but some of Jamfiles adds its own. If -Wall is added then it could re-enable some warnings. For example:

BuildSetup defines:

HAIKU_WARNING_CCFLAGS = -Wall -Wno-trigraphs ...

src/add-ons/kernel/drivers/network/etherpci/Jamfile defines:

SubDirCcFlags -Wall ;

and the final CFLAGS are:

-Wall -Wno-trigraphs ... -Wall

Since -Wall implies -Wtrigraphs, the final result may be different then expected.

Change History (5)

by kaliber, 14 years ago

Attachment: remove-wall.patch added

comment:1 by kaliber, 14 years ago

patch: 01

comment:2 by kaliber, 13 years ago

Ping.

comment:3 by stippi, 13 years ago

Owner: changed from bonefish to stippi
Status: newin-progress

Patch looks fine to me. Will see if it still applies cleanly.

comment:4 by stippi, 13 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.