Opened 9 years ago

Closed 9 years ago

#6350 closed enhancement (fixed)

PATCH: Device manager shows large number of "Unknown Devices" for ACPI objects

Reported by: kallisti5 Owned by: phoudoin
Priority: normal Milestone: R1
Component: Applications/Devices Version: R1/Development
Keywords: Cc: phoudoin, tqh
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description (last modified by mmadia)

Device manager shows large number of "Unknown Devices" for ACPI objects

This moves towards a DeviceACPI or DeviceIO handler for non-pci devices. I also cleaned up some static references.

See attached:

  • Patch
  • Before screenshot
  • After ('final*') screenshot

Attachments (7)

before.png (70.6 KB) - added by kallisti5 9 years ago.
before patch
final-category.png (45.6 KB) - added by kallisti5 9 years ago.
final result - category
final-connection.png (48.2 KB) - added by kallisti5 9 years ago.
final - connection
early-acpi-support.diff (5.6 KB) - added by kallisti5 9 years ago.
Final patch, basic ACPI node support
early-acpi-support.r2.diff (5.4 KB) - added by kallisti5 9 years ago.
early-acpi-support.r3.diff (5.7 KB) - added by kallisti5 9 years ago.
revision 3, now identifies important ACPI root nodes.
final-connection-r3.png (36.3 KB) - added by kallisti5 9 years ago.
example of ACPI root nodes on hrev3 of patch

Download all attachments as: .zip

Change History (18)

comment:1 Changed 9 years ago by kallisti5

Has a Patch: set

Changed 9 years ago by kallisti5

Attachment: before.png added

before patch

comment:2 Changed 9 years ago by kallisti5

note the two diff's are the same.. strange duplicate upload.

comment:3 Changed 9 years ago by kallisti5

Implementing a DeviceAPCI class.. almost done. Once it is complete things will look a heck of a lot better.

Last edited 9 years ago by kallisti5 (previous) (diff)

comment:4 Changed 9 years ago by kallisti5

see attached patch thats adds basic ACPI support. We don't do much probing on ACPI nodes yet. Based on DevicePCI

Changed 9 years ago by kallisti5

Attachment: final-category.png added

final result - category

Changed 9 years ago by kallisti5

Attachment: final-connection.png added

final - connection

Changed 9 years ago by kallisti5

Attachment: early-acpi-support.diff added

Final patch, basic ACPI node support

comment:5 Changed 9 years ago by mmadia

Description: modified (diff)

deleted some attachments per kallisti's request.

comment:6 Changed 9 years ago by kallisti5

little note, the TODO comment on 315/316 in src/apps/devices/DevicesView.cpp should be omitted as I went ahead and did it. :)

Changed 9 years ago by kallisti5

Attachment: early-acpi-support.r2.diff added

comment:7 Changed 9 years ago by phoudoin

Cc: phoudoin added

comment:8 Changed 9 years ago by tqh

Cc: tqh added

I'm currently in the process of moving, so havn't looked at your work, but it's very welcome.

Changed 9 years ago by kallisti5

Attachment: early-acpi-support.r3.diff added

revision 3, now identifies important ACPI root nodes.

Changed 9 years ago by kallisti5

Attachment: final-connection-r3.png added

example of ACPI root nodes on hrev3 of patch

comment:9 Changed 9 years ago by kallisti5

(latest patches attached have all of the code previous patches have making previous revisions obsolete )

comment:10 Changed 9 years ago by phoudoin

Owner: changed from nobody to phoudoin
Status: newin-progress

comment:11 Changed 9 years ago by phoudoin

Resolution: fixed
Status: in-progressclosed

Patch applied in hrev37757.

Note: See TracTickets for help on using tickets.