Opened 14 years ago

Closed 14 years ago

#6350 closed enhancement (fixed)

PATCH: Device manager shows large number of "Unknown Devices" for ACPI objects

Reported by: kallisti5 Owned by: phoudoin
Priority: normal Milestone: R1
Component: Applications/Devices Version: R1/Development
Keywords: Cc: phoudoin, tqh
Blocked By: Blocking:
Platform: All

Description (last modified by mmadia)

Device manager shows large number of "Unknown Devices" for ACPI objects

This moves towards a DeviceACPI or DeviceIO handler for non-pci devices. I also cleaned up some static references.

See attached:

  • Patch
  • Before screenshot
  • After ('final*') screenshot

Attachments (7)

before.png​ (70.6 KB ) - added by kallisti5 14 years ago.
before patch
final-category.png​ (45.6 KB ) - added by kallisti5 14 years ago.
final result - category
final-connection.png​ (48.2 KB ) - added by kallisti5 14 years ago.
final - connection
early-acpi-support.diff​ (5.6 KB ) - added by kallisti5 14 years ago.
Final patch, basic ACPI node support
early-acpi-support.r2.diff​ (5.4 KB ) - added by kallisti5 14 years ago.
early-acpi-support.r3.diff​ (5.7 KB ) - added by kallisti5 14 years ago.
revision 3, now identifies important ACPI root nodes.
final-connection-r3.png​ (36.3 KB ) - added by kallisti5 14 years ago.
example of ACPI root nodes on hrev3 of patch

Download all attachments as: .zip

Change History (18)

comment:1 by kallisti5, 14 years ago

patch: 0 → 1

by kallisti5, 14 years ago

Attachment: before.png​ added

before patch

comment:2 by kallisti5, 14 years ago

note the two diff's are the same.. strange duplicate upload.

comment:3 by kallisti5, 14 years ago

Looking through the ACPI specs, ACPI connects through a "Function Fixed Hardware (FFH) Interface"

I think I am going to work on a DeviceFFH to address the ACPI devices in my spare time. Don't expect anything crazy for a while.. the diffs attached to this Trac now are valid and should be included as it lays out the groundwork for a FFH (or whatever) handler to handle non-PCI devices (maybe GPIO in the future?)

Version 0, edited 14 years ago by kallisti5 (next)

comment:4 by kallisti5, 14 years ago

see attached patch thats adds basic ACPI support. We don't do much probing on ACPI nodes yet. Based on DevicePCI

by kallisti5, 14 years ago

Attachment: final-category.png​ added

final result - category

by kallisti5, 14 years ago

Attachment: final-connection.png​ added

final - connection

by kallisti5, 14 years ago

Attachment: early-acpi-support.diff​ added

Final patch, basic ACPI node support

comment:5 by mmadia, 14 years ago

Description: modified (diff)

deleted some attachments per kallisti's request.

comment:6 by kallisti5, 14 years ago

little note, the TODO comment on 315/316 in src/apps/devices/DevicesView.cpp should be omitted as I went ahead and did it. :)

by kallisti5, 14 years ago

Attachment: early-acpi-support.r2.diff​ added

comment:7 by phoudoin, 14 years ago

Cc: phoudoin added

comment:8 by tqh, 14 years ago

Cc: tqh added

I'm currently in the process of moving, so havn't looked at your work, but it's very welcome.

by kallisti5, 14 years ago

Attachment: early-acpi-support.r3.diff​ added

revision 3, now identifies important ACPI root nodes.

by kallisti5, 14 years ago

Attachment: final-connection-r3.png​ added

example of ACPI root nodes on hrev3 of patch

comment:9 by kallisti5, 14 years ago

(latest patches attached have all of the code previous patches have making previous revisions obsolete )

comment:10 by phoudoin, 14 years ago

Owner: changed from nobody to phoudoin
Status: new → in-progress

comment:11 by phoudoin, 14 years ago

Resolution: → fixed
Status: in-progress → closed

Patch applied in hrev37757.

Note: See TracTickets for help on using tickets.