[Tracker] several strings not yet translated (patch)

[diver]

This is hrev37723

​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FilePermissionsView.cpp#L65 ("Owner")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2385 ("contains")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2386 ("is")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2387 ("is not")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2388 ("starts with")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2389 ("ends with")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FSUtils.cpp#L1101 ("copy")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FSUtils.cpp#L1408 ("copy")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/InfoWindow.cpp#L434 ("rename")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/InfoWindow.cpp#L1223 ("rename")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/NavMenu.cpp#L791 ("parent folder")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L152 ("Open with:")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1440 ("Preferred for file")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1455 ("Handles any file")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1470 ("Handles any ")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1482 ("Preferred for ")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1484 ("Handles )
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1496 ("Does not handle file")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/SettingsViews.cpp#L802 ("Separator:")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/StatusWindow.cpp#L665 ("To: ")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/StatusWindow.cpp#L687 ("of")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/StatusWindow.cpp#L693 ("/s")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/StatusWindow.cpp#L701 ("/s")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/TextWidget.cpp#L330 ("rename")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/RegExp.cpp#L175 - list of error strings

[aldeck]

Thanks for the detailed report, i'm puting Takashi Murai in cc as he is probably interested to work on a patch (though he is still in vacations until August 15, so anyone motivated this weekend, patches are welcome :-))

[diver]

There is also ​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L256 ("default"), which is used as default query template and stored in "/boot/home/queries/default" but I'm not sure it should be translated. Thoughts?

[aldeck]

forgot to actually add mt

[mt]

Thanks diver for pointing out. I will add patch, please review. I think default query template name need not to translate. I think we need to translate folders name in /boot (system, apps ...) and in /boot/home (config, mail, queries...) like Trash and Desktop. but currently I have no idea.

[diver]

​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L668 ("Could not find application \")
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L679 ("The application \"" << pose->TargetModel()->Name() << "\" does not support the type of document you are about to open. Are you sure you want to proceed? If you know that the application supports the document type, you should contact the publisher of the application and ask them to update their application to list the type of your document as supported.")

[mt]

Hi, I update patch.

[diver]

Not sure about this one:
​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2805 ("Name")

[diver]

​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FSUtils.cpp#L1991 (bytes)

[mt]

I update patch, please review.
TODO: In FindPanel.cpp, We need modify TAttrView::GetDefaultName(), FindPanel::GetDefaultName() and FindWindow::GetDefaultName() to display localized title correctly.

[diver]

Could someone please commit it?

[aldeck]

Working on it :) Sorry for the delay, i wasn't available.

[aldeck]

Sorry for the delay as i had to struggle with my development workstation.

I have problems with the patch, the RegExp.cpp changes break the build because the "collectcatkeys" program (in src/bin/locale) depends on it (which is a bit dirty imho), and it can't be localized the same way. You might need to do a full build (or rebuild only collectcatkey) to notice that. I don't know what Adrien (pulkomandy) or others wants to do about that.

Otherwise, small annoyances are the 80 char limit and the fact that the patch isn't relative to the root working copy dir. (please use svn diff src/kits/tracker from the root of the working copy)

Thanks.

[pulkomandy]

The collectcatkeys in src/bin/locale isn't used while building, the one in src/tools/locale is. If there is no other way, RegExp.cpp should have an unlocalized version in src/tools/ for it.

[mt]

Hi, I update patch (use svn diff src/kits/tracker and 80 char limit).

[stippi]

Looks perfect, thanks!

[stippi]

Applied in hrev38675. Thanks a bunch!

[aldeck]

Reverted the change on RegExp.cpp in hrev38679

Reopening until this issue is sorted out.

[diver]

Several default column names are not translated, see ​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/TrackerInitialState.cpp#L123

[diver]

​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/NavMenu.cpp#L791 ("parent folder")

[mt]

Replying to diver:

Several default column names are not translated, see ​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/TrackerInitialState.cpp#L123

Hi, I make patch for tranlating columns ,mime description and attribute name in TrackerInitialState.cpp, please review.

• StringToStream() and BColumnToStream() may go to BColumn class if there is no compatibility problem in libtracker.so.
  
• If Column width does not fit with translated title, we may use B_TRANSLATE macro to width and offset.

[aldeck]

I'll be in vacation for around two weeks (starting tomorrow until oct 17). Anyone, feel free to work on this (or any other ticket i'm following). @mt i hope to meet you in Japan ;-)

[mt]

Replying to diver:

​http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/NavMenu.cpp#L791 ("parent folder")

Diver, thanks to point out!!, I add B_TRANSLATE to "parent folder" and style changes.

@aldeck Enjoy vacation and welcome to Japan!

[anevilyak]

I've applied the nav menu patch in hrev38859. However, the TrackerInitialState patch has some issues I'm less than certain about. Specifically it also localizes some of the strings going into the MIME database, which shouldn't be.

[mt]

Sorry for the late reply, I removed MIME localizing from TrackerInitialState patch. please check.

[deejam]

Is this ticket still valid after all the localization work done by several developers? I checked all of the strings mentioned in this ticket and the only one that is not localized is the RegExp.cpp ("list of error strings"). Shall that be localized? Otherwise, this ticket could be closed.

[diver]

There is still TrackerInitialState part.

[pulkomandy]

Fixed both remaining issues in hrev50550.