Opened 9 years ago

Closed 3 years ago

#6374 closed bug (fixed)

[Tracker] several strings not yet translated (patch)

Reported by: diver Owned by: stippi
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/Development
Keywords: Cc: mt, pulkomandy
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

This is hrev37723

http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FilePermissionsView.cpp#L65 ("Owner")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2385 ("contains")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2386 ("is")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2387 ("is not")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2388 ("starts with")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L2389 ("ends with")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FSUtils.cpp#L1101 ("copy")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FSUtils.cpp#L1408 ("copy")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/InfoWindow.cpp#L434 ("rename")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/InfoWindow.cpp#L1223 ("rename")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/NavMenu.cpp#L791 ("parent folder")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L152 ("Open with:")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1440 ("Preferred for file")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1455 ("Handles any file")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1470 ("Handles any ")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1482 ("Preferred for ")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1484 ("Handles )
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L1496 ("Does not handle file")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/SettingsViews.cpp#L802 ("Separator:")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/StatusWindow.cpp#L665 ("To: ")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/StatusWindow.cpp#L687 ("of")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/StatusWindow.cpp#L693 ("/s")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/StatusWindow.cpp#L701 ("/s")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/TextWidget.cpp#L330 ("rename")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/RegExp.cpp#L175 - list of error strings

Attachments (7)

tracker.patch (10.0 KB ) - added by mt 9 years ago.
tracker.2.patch (12.4 KB ) - added by mt 9 years ago.
tracker.3.patch (13.2 KB ) - added by mt 9 years ago.
tracker.4.patch (13.8 KB ) - added by mt 9 years ago.
TrackerInitialState.cpp.patch (29.1 KB ) - added by mt 9 years ago.
NavMenu.cpp.patch (19.3 KB ) - added by mt 9 years ago.
TrackerInitialState.cpp.2.patch (12.8 KB ) - added by mt 9 years ago.

Download all attachments as: .zip

Change History (37)

comment:1 by aldeck, 9 years ago

Owner: changed from axeld to aldeck
Status: newassigned

Thanks for the detailed report, i'm puting Takashi Murai in cc as he is probably interested to work on a patch (though he is still in vacations until August 15, so anyone motivated this weekend, patches are welcome :-))

comment:2 by diver, 9 years ago

There is also http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/FindPanel.cpp#L256 ("default"), which is used as default query template and stored in "/boot/home/queries/default" but I'm not sure it should be translated. Thoughts?

comment:3 by aldeck, 9 years ago

Cc: mt added

forgot to actually add mt

comment:4 by mt, 9 years ago

Thanks diver for pointing out. I will add patch, please review. I think default query template name need not to translate. I think we need to translate folders name in /boot (system, apps ...) and in /boot/home (config, mail, queries...) like Trash and Desktop. but currently I have no idea.

by mt, 9 years ago

Attachment: tracker.patch added

comment:5 by mt, 9 years ago

Has a Patch: set

comment:6 by diver, 9 years ago

http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L668 ("Could not find application \")
http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/OpenWithWindow.cpp#L679 ("The application \"" << pose->TargetModel()->Name() << "\" does not support the type of document you are about to open. Are you sure you want to proceed? If you know that the application supports the document type, you should contact the publisher of the application and ask them to update their application to list the type of your document as supported.")

comment:7 by mt, 9 years ago

Hi, I update patch.

by mt, 9 years ago

Attachment: tracker.2.patch added

comment:10 by mt, 9 years ago

I update patch, please review.
TODO: In FindPanel.cpp, We need modify TAttrView::GetDefaultName(), FindPanel::GetDefaultName() and FindWindow::GetDefaultName() to display localized title correctly.

by mt, 9 years ago

Attachment: tracker.3.patch added

comment:11 by diver, 9 years ago

Could someone please commit it?

comment:12 by diver, 9 years ago

Summary: [Tracker] several strings not yet translated[Tracker] several strings not yet translated (patch)

comment:13 by aldeck, 9 years ago

Status: assignedin-progress

Working on it :) Sorry for the delay, i wasn't available.

comment:14 by aldeck, 9 years ago

Sorry for the delay as i had to struggle with my development workstation.

I have problems with the patch, the RegExp.cpp changes break the build because the "collectcatkeys" program (in src/bin/locale) depends on it (which is a bit dirty imho), and it can't be localized the same way. You might need to do a full build (or rebuild only collectcatkey) to notice that. I don't know what Adrien (pulkomandy) or others wants to do about that.

Otherwise, small annoyances are the 80 char limit and the fact that the patch isn't relative to the root working copy dir. (please use svn diff src/kits/tracker from the root of the working copy)

Thanks.

comment:15 by aldeck, 9 years ago

Cc: pulkomandy added

comment:16 by pulkomandy, 9 years ago

The collectcatkeys in src/bin/locale isn't used while building, the one in src/tools/locale is. If there is no other way, RegExp.cpp should have an unlocalized version in src/tools/ for it.

comment:17 by mt, 9 years ago

Hi, I update patch (use svn diff src/kits/tracker and 80 char limit).

by mt, 9 years ago

Attachment: tracker.4.patch added

comment:18 by stippi, 9 years ago

Owner: changed from aldeck to stippi

Looks perfect, thanks!

comment:19 by stippi, 9 years ago

Resolution: fixed
Status: in-progressclosed

Applied in hrev38675. Thanks a bunch!

comment:20 by aldeck, 9 years ago

Resolution: fixed
Status: closedreopened

Reverted the change on RegExp.cpp in hrev38679

Reopening until this issue is sorted out.

Last edited 9 years ago by aldeck (previous) (diff)

comment:21 by diver, 9 years ago

in reply to:  21 comment:23 by mt, 9 years ago

Replying to diver:

Several default column names are not translated, see http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/TrackerInitialState.cpp#L123

Hi, I make patch for tranlating columns ,mime description and attribute name in TrackerInitialState.cpp, please review.

  • StringToStream() and BColumnToStream() may go to BColumn class if there is no compatibility problem in libtracker.so.
  • If Column width does not fit with translated title, we may use B_TRANSLATE macro to width and offset.

comment:24 by aldeck, 9 years ago

I'll be in vacation for around two weeks (starting tomorrow until oct 17). Anyone, feel free to work on this (or any other ticket i'm following). @mt i hope to meet you in Japan ;-)

in reply to:  22 comment:25 by mt, 9 years ago

Replying to diver:

http://dev.haiku-os.org/browser/haiku/trunk/src/kits/tracker/NavMenu.cpp#L791 ("parent folder")

Diver, thanks to point out!!, I add B_TRANSLATE to "parent folder" and style changes.

@aldeck Enjoy vacation and welcome to Japan!

by mt, 9 years ago

Attachment: NavMenu.cpp.patch added

comment:26 by anevilyak, 9 years ago

I've applied the nav menu patch in hrev38859. However, the TrackerInitialState patch has some issues I'm less than certain about. Specifically it also localizes some of the strings going into the MIME database, which shouldn't be.

comment:27 by mt, 9 years ago

Sorry for the late reply, I removed MIME localizing from TrackerInitialState patch. please check.

comment:28 by deejam, 8 years ago

Is this ticket still valid after all the localization work done by several developers? I checked all of the strings mentioned in this ticket and the only one that is not localized is the RegExp.cpp ("list of error strings"). Shall that be localized? Otherwise, this ticket could be closed.

comment:29 by diver, 8 years ago

There is still TrackerInitialState part.

comment:30 by pulkomandy, 3 years ago

Resolution: fixed
Status: reopenedclosed

Fixed both remaining issues in hrev50550.

Note: See TracTickets for help on using tickets.