[Installer] not enough chars to store translated string (patch)

[diver]

This is hrev38644.

If you select Russian locale in ReadOnlyBootPrompt and then start Installer you'll see question marks in the black diamonds in the drop down menus. See screenshot.

[diver]

possible patch

[korli]

It seems ok to be applied.

[anevilyak]

Applied in hrev38647. Thanks!

[siarzhuk]

Aren't those "black diamonds" the sign that current implementation of "string_for_size" function is buggy? Looks like the string was just cut out regardless of real character boundaries. UTF-8 is not fixed-size symbol encoding. And much more elegant solution would be translating with "..." at end in case proposed buffer is not enough, IMO. Anyway this is a partial solution and I'm not sure, that 20 bytes "will be enough" for any language. ;-)

[siarzhuk]

By the way another potential place for the same problem:

src/kits/tracker/InfoWindow.cpp

1548                 char capacityStr[16], usedStr[16], freeStr[16];
1549                 string_for_size(capacity, capacityStr, sizeof(capacityStr));
1550                 string_for_size(capacity - fFreeBytes, usedStr, sizeof(usedStr));
1551                 string_for_size(fFreeBytes, freeStr, sizeof(freeStr));

Other occuriences of using "string_for_size" are using either 1024 or 128 bytes for result buffer. ;-)

[korli]

To me, if the bug reporter tested the patch OK, it is good enough. Please create a more general bug for the string_for_size() API problem.