Date-columns overwriting column borders

[humdinger]

This is hrev39138.

Date columns like "Modified" or "Created" or email's "When" are redrawn over their column borders. For example, open a Tracker window with Name, Size, Modified columns.
Now move the Size column to the right of Modified.

hrev39123 may be the culprit.

[humdinger]

Name - Size - Modified

[humdinger]

Name - Modified - Size

[myob]

To comment on this, I can remember when the date format would "collapse" down from the verbose one shown to ever more compact versions as you narrowed a column, down to dd/mm/yy at the lowest width.

I found this bug by searching before I posted another; this doesn't appear to happen with any other column type in testing.

[aldeck]

Yes, hrev39123 is the culprit. The semantics changed for BLocale::FormatDateTime used in WidgetAttributeText. It now returns a size_t, where it was a status_t before. Thus the check for "== B_OK" that fails even if everything is ok, it should now be ">= 0". Confirmed working here, though i wonder if the change in BLocale was really intended that way (cc'ing to zooey).

[zooey]

Right, the change in hrev39123 was intended (consolidation of different methods returning status_t or ssize_t). However, I obviously failed to adjust all callers ...

[zooey]

Fixed in hrev39649 (which additionally restores the original set of 6 date formats).

[humdinger]

Thanks very much! The ugliness was quite annoying. :)