Click ing on video picture and dragging Mediaplayer dissapears off screen

[kutspam@…]

Click on the video being put out by mediaplayer and drag it to the edge of the screen. Mediaplayer will be completely off screen but running. Clicking on the Mediaplayer item in deskbar will not reveal Mediaplayer.

[nielx]

Move to the proper component.

[leavengood]

Should be fixed in hrev25234.

[marcusoverhagen]

I haven't tested the change yet, but I don't think the behaviour is wanted.

1) It shouldn't be possible to move the MediaPlayer offscreen, that looks like there is bug somewhere.

2) It must be possible to move parts of the MediaPlayer out of the screen, without it jumping back.

[leavengood]

Replying to marcusoverhagen:

I haven't tested the change yet, but I don't think the behaviour is wanted.

1) It shouldn't be possible to move the MediaPlayer offscreen, that looks like there is bug somewhere.

In my testing, you can't move it completely offscreen, there is always a sliver where the mouse cannot move any farther over. But a novice user might not realize that and think the window is gone. I assume that is why this bug was logged.

It can be definitely hard to see that sliver if the menu, controls and border are turned off.

2) It must be possible to move parts of the MediaPlayer out of the screen, without it jumping back.

Well either I could revert this change and we drop the bug, or the "jumping back" behavior could only happen if some large percentage of the window is offscreen.

In general though it would be nice if these bugs were dropped before someone spends time to make a fix. That is just a waste of everyone's time. I assumed a 2 year old bug was valid.

[mmlr]

Are you sure that it was not bug #1307 that may have caused the MediaPlayer to actually jump completely offscreen in this case? Of course if you drag the application under normal circumstances it is of course not possible to move it completely offscreen, but with bug #1307 in mind it doesn't sound totally unlikely to me that this just happened by accident.

[leavengood]

Replying to mmlr:

Are you sure that it was not bug #1307 that may have caused the MediaPlayer to actually jump completely offscreen in this case? Of course if you drag the application under normal circumstances it is of course not possible to move it completely offscreen, but with bug #1307 in mind it doesn't sound totally unlikely to me that this just happened by accident.

Yeah that could be the problem. In which case maybe we should leave this fix until that bug is resolved. Though I could still make the jumping only happen in the extreme cases of most or all of the window being offscreen.

Because I will admit behavior like this can be annoying when you don't want it happening.

[axeld]

I think it should only jump back when there is less then like a 10 pixel span on screen left. Probably (when #1307 is fixed), this should only take action when the app is started (ie. the screen resolution may have changed, etc.).

[jackburton]

Could this have been fixed in hrev26491 ?

[stippi]

I am with Michael that the jumping off screen was actually a dup of #1307. That being said, I think the jumping on screen in WindowActivated() can be a little irritating. I may have a look.

[leavengood]

Replying to stippi:

I am with Michael that the jumping off screen was actually a dup of #1307. That being said, I think the jumping on screen in WindowActivated() can be a little irritating. I may have a look.

Since I originally added it, I have taken that code out as of hrev31551.

[stippi]

Something similar could still be useful. At least I would want the MediaPlayer to shrink to fit the screen if the video is very large. For example, my vacation clips are 1920x1080 and my screen is 1920x1200, and then some of MediaPlayer window is out of bounds... with your code in place, it would at least center itself. :-) But what probably doesn't make sense anymore is the repositioning on activation.

[leavengood]

Well feel free to resurrect my code in a more appropiate place, if you think it is useful. Like I said in the commit I still think that code is nice looking :)

[stippi]

I came up with something... the screen frame check is now only done when the current clip changes such that the video size changes.

[stippi]

Looking at your patch again, I see that I came up with almost the identical code, but before I run that, I also check if the window is actually larger than the screen in any dimension and scale it down. But... it still means your code lives on. :-)