Opened 12 years ago

Closed 5 months ago

#6781 closed bug (fixed)

mkfs -t bfs KDLs on small image files

Reported by: jonas.kirilla Owned by: axeld
Priority: normal Milestone: R1/beta4
Component: File Systems/BFS Version: R1/Development
Keywords: KDL Cc:
Blocked By: Blocking: #14004
Platform: All

Description (last modified by diver)

PANIC: ASSERT FAILED (../haiku-git/src/add-ons/kernel/file_systems/bfs/BlockAllocator.cpp:381): start + length <= (int32)fNumBits

dd if=/dev/zero of=tmp bs=1M count=1
mkfs -t bfs tmp
(type yes)

==> KDL

If it doesn't, try a smaller image, like 1k.

On hrev39121.

Change History (8)

comment:1 by pulkomandy, 8 years ago

Still happens.

If I'm reading the code correctly, the minimal log size is 512 blocks (set in Volume::Initialize). But disk_super_block::IsValid() considers volumes as small as 10 blocks as valid. So it's possible that the log (and other superblock structures) end up not fitting the volume.

I'm not sure what the milimal size should be, or if we should somehow disable the log for very small volumes. So I'll let someone with better BFS knowledge decde what the correct fix is.

comment:2 by waddlesplash, 4 years ago

axeld, what should we do here?

comment:3 by waddlesplash, 4 years ago

Blocking: 14004 added

comment:4 by waddlesplash, 4 years ago

Component: System/KernelFile Systems/BFS

comment:5 by waddlesplash, 4 years ago

Keywords: KDL added

comment:6 by diver, 11 months ago

Description: modified (diff)

comment:8 by waddlesplash, 5 months ago

Milestone: R1R1/beta4
Resolution: fixed
Status: newclosed

Fix merged in hrev56445.

Note: See TracTickets for help on using tickets.