Opened 9 years ago

Last modified 8 weeks ago

#6781 new bug

mkfs -t bfs KDLs on small image files

Reported by: jonas.kirilla Owned by: axeld
Priority: normal Milestone: R1
Component: File Systems/BFS Version: R1/Development
Keywords: KDL Cc:
Blocked By: Blocking: #14004
Has a Patch: no Platform: All

Description

dd if=/dev/zero of=tmp bs=1M count=1
mkfs -t bfs tmp
(type yes)

==> KDL

If it doesn't, try a smaller image, like 1k.

On hrev39121.

Change History (5)

comment:1 by pulkomandy, 5 years ago

Still happens.

If I'm reading the code correctly, the minimal log size is 512 blocks (set in Volume::Initialize). But disk_super_block::IsValid() considers volumes as small as 10 blocks as valid. So it's possible that the log (and other superblock structures) end up not fitting the volume.

I'm not sure what the milimal size should be, or if we should somehow disable the log for very small volumes. So I'll let someone with better BFS knowledge decde what the correct fix is.

comment:2 by waddlesplash, 4 months ago

axeld, what should we do here?

comment:3 by waddlesplash, 4 months ago

Blocking: 14004 added

comment:4 by waddlesplash, 8 weeks ago

Component: System/KernelFile Systems/BFS

comment:5 by waddlesplash, 8 weeks ago

Keywords: KDL added
Note: See TracTickets for help on using tickets.