Opened 8 years ago

Last modified 4 years ago

#6781 new bug

mkfs -t bfs KDLs on small image files

Reported by: jonas.kirilla Owned by: axeld
Priority: normal Milestone: R1
Component: System/Kernel Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All


dd if=/dev/zero of=tmp bs=1M count=1
mkfs -t bfs tmp
(type yes)

==> KDL

If it doesn't, try a smaller image, like 1k.

On hrev39121.

Change History (1)

comment:1 Changed 4 years ago by pulkomandy

Still happens.

If I'm reading the code correctly, the minimal log size is 512 blocks (set in Volume::Initialize). But disk_super_block::IsValid() considers volumes as small as 10 blocks as valid. So it's possible that the log (and other superblock structures) end up not fitting the volume.

I'm not sure what the milimal size should be, or if we should somehow disable the log for very small volumes. So I'll let someone with better BFS knowledge decde what the correct fix is.

Note: See TracTickets for help on using tickets.