Opened 9 years ago

Closed 7 years ago

#6978 closed bug (fixed)

[WebPositive] middle click should open a new tab on mouse down

Reported by: diver Owned by: leavengood
Priority: normal Milestone: R1
Component: Applications/WebPositive Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Middle click outside tabs should always open a new tab on mouse down instead of mouse up.
See http://mmlr.dyndns.org/changeset/474

Change History (12)

comment:1 by stippi, 9 years ago

I can't lookup the changeset right now, but I have a faint memory that I implemented it this way for a good reason... :-)

comment:2 by diver, 9 years ago

http://webpositive.haiku-os.org/changeset/474
Also close existing tab on middle mouse down like it's done in Terminal.

Last edited 9 years ago by diver (previous) (diff)

comment:3 by stippi, 9 years ago

I am against that, too, since it works against regular button behavior. The little thingy pretends to be a button, why make it work differently? It's done like it is on purpose. And it works like that also on other systems. If Terminal works differently, it should be fixed instead.

Last edited 9 years ago by stippi (previous) (diff)

comment:4 by diver, 9 years ago

What little thingy? Do you mean that small close button on a tab?

comment:5 by diver, 9 years ago

I'm not talking about close button. What I mean is that middle mouse button should close current tab or create new one on middle mouse down, not middle mouse up. It somewhat improves responsiveness of an application. At least it does in Opera.

Last edited 9 years ago by diver (previous) (diff)

comment:6 by diver, 9 years ago

ping stippi

comment:7 by stippi, 9 years ago

Yes, I misunderstood. But with regards to what you actually meant, I would like to refer to my very first comment. Can't say more without reviewing the code.

comment:8 by diver, 8 years ago

I've found a good explanation for this feature which pretty much sums up everything I wanted to say in the ticket description:

"Most operations on the tab row in other browsers now respond to mouse down events rather than up events for perceived performance reasons. It's quite literally half a click faster to switch tabs or close a tab on down.

Yes, it means you can't cancel a tab switch or tab close action once you've started. This is a case of optimizing UI for the vastly more common operation (switch or close a tab) by removing the uncommon operation (abort a switch or close tab operation by moving the mouse away and releasing). For some operations it's still appropriate to allow cancellation so the action is performanced on mouse up.

Rigid decades-old "always respond to mouse up so the user can cancel the operation" rules aren't correct for all circumstances.

To a lot of people, down feels "quicker" and "natural". I recall that Firefox used to switch tabs on mouseup and somewhere along the way (2.0 I think) they switched to mousedown as well."

comment:9 by stippi, 8 years ago

Your reasoning makes sense that one should optimize for the common use-case. There are two problems with this:

  • The uncommon use-case is not simply unoptimized, but it becomes impossible to perform. However, I can't remember the last time when I've actually performed it or needed to perform it. So this problem is void.
  • The bigger issue is that your reasoning can be applied to the Haiku user interface in general. So I would prefer this to be changed everywhere, like all BControls, window buttons, everywhere, rather than in one application introducing inconsistency.

comment:10 by diver, 8 years ago

How about changing this in BTab for a start?

comment:11 by leavengood, 8 years ago

Owner: changed from stippi to leavengood
Status: newassigned

I think before we start changing core behaviors in Haiku, changing Web+ is a nice "testing ground."

Though we now have another ticket very closely related to this (#7786), and I think twinbee makes some good points, and he knows what he is talking about when it comes to latency in operating systems.

In general I think the sensible and safe road is to make most non-destructive operations operate on mouse-down. I'll eventually add a tab closing undo stack to Web+ so even that will become non-destructive too. Then maybe we could have an option to make other actions such as button clicks happen on mouse down.

comment:12 by leavengood, 7 years ago

Resolution: fixed
Status: assignedclosed

Fixed in hrev44432. There is still #7786 for the general use of mouse down in Haiku to improve latency, so I'm closing this one.

Note: See TracTickets for help on using tickets.