Opened 14 years ago
Closed 14 years ago
#7004 closed enhancement (fixed)
Filling empty BIconRule methods
| Reported by: | Karvjorm | Owned by: | nobody |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Preferences | Version: | R1/Development |
| Keywords: | Notifications BIconRule | Cc: | Karvjorm |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Notification preflet's BIconRule methods RemoveIconAt(index) and RemoveAllIcons were empty, so they can be considered as a bug, can't they? I have impelemented them in the enclosed patch.
Attachments (1)
Change History (5)
comment:1 by , 14 years ago
| Type: | bug → enhancement |
|---|---|
| Version: | R1/alpha2 → R1/Development |
comment:2 by , 14 years ago
by , 14 years ago
| Attachment: | BIconRuleRemoveIcons.patch added |
|---|
An updated BIconRuleRemoveIcons patch
comment:3 by , 14 years ago
| patch: | 0 → 1 |
|---|
comment:4 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Applied in hrev39903. I adapted it a bit, I hope you don't mind. Thanks a lot!
Note:
See TracTickets
for help on using tickets.
Hi Karvjorm,
Could you please change this class to use a BObjectList instead of a BList? Also a non-pointer "items" member would be better.
The patch should also be generated from the root of the source tree (svn diff src/preferences/notifications/) Thanks.