Opened 12 years ago

Closed 12 years ago

#7004 closed enhancement (fixed)

Filling empty BIconRule methods

Reported by: Karvjorm Owned by: nobody
Priority: normal Milestone: R1
Component: Preferences Version: R1/Development
Keywords: Notifications BIconRule Cc: Karvjorm
Blocked By: Blocking:
Platform: All


Notification preflet's BIconRule methods RemoveIconAt(index) and RemoveAllIcons were empty, so they can be considered as a bug, can't they? I have impelemented them in the enclosed patch.

Attachments (1)

BIconRuleRemoveIcons.patch (1.9 KB ) - added by Karvjorm 12 years ago.
An updated BIconRuleRemoveIcons patch

Download all attachments as: .zip

Change History (5)

comment:1 by anevilyak, 12 years ago

Type: bugenhancement
Version: R1/alpha2R1/Development

comment:2 by korli, 12 years ago

Hi Karvjorm,

Could you please change this class to use a BObjectList instead of a BList? Also a non-pointer "items" member would be better.

The patch should also be generated from the root of the source tree (svn diff src/preferences/notifications/) Thanks.

by Karvjorm, 12 years ago

Attachment: BIconRuleRemoveIcons.patch added

An updated BIconRuleRemoveIcons patch

comment:3 by Karvjorm, 12 years ago

patch: 01

comment:4 by korli, 12 years ago

Resolution: fixed
Status: newclosed

Applied in hrev39903. I adapted it a bit, I hope you don't mind. Thanks a lot!

Note: See TracTickets for help on using tickets.