Opened 8 years ago

Closed 5 years ago

Last modified 5 years ago

#7088 closed enhancement (fixed)

[BootManager] show disk icons on Drives page

Reported by: diver Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/BootManager Version: R1/Development
Keywords: Cc: axeld
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Attachments (2)

bootman_mockup.png (35.3 KB) - added by diver 8 years ago.
0001-add-the-drive-s-icon-in-front-of-its-name-in-drive-l.patch (2.5 KB) - added by frizer23 5 years ago.

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by diver

Attachment: bootman_mockup.png added

comment:1 Changed 8 years ago by laplace

Cc: axeld added

comment:2 Changed 8 years ago by laplace

Owner: changed from laplace to axeld
Status: newassigned

Reassigned to Axel, as I am not sure, if CC did work.

comment:3 Changed 8 years ago by diver

In case there are several identical drives it would be nice to show hard drive model somewhere (tooltip?) to distinguish them.

comment:4 Changed 8 years ago by diver

Ah, it's already the case since hrev40231 :-)

comment:5 Changed 8 years ago by diver

On the second thought if drives are identical then models would be identical too. That's when serial numbers could come into play.

comment:6 Changed 5 years ago by frizer23

Has a Patch: set

comment:7 Changed 5 years ago by stippi

Thanks for the patch! It looks good, but you need to delete fIcon in the destructor. Also, if device.GetIcon() fails (it has a return code, I believe), you could memset(fIcon->Bits(), 0, fIcon->BitsLength()) to draw a transparent icon.

comment:8 Changed 5 years ago by jessicah

Resolution: fixed
Status: assignedclosed

Applied in hrev47869, including fixes recommended by stippi.

comment:9 Changed 5 years ago by korli

Still the include order is wrong :)

Note: See TracTickets for help on using tickets.