Opened 13 years ago

Closed 10 years ago

Last modified 10 years ago

#7088 closed enhancement (fixed)

[BootManager] show disk icons on Drives page

Reported by: diver Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/BootManager Version: R1/Development
Keywords: Cc: axeld
Blocked By: Blocking:
Platform: All

Description

Attachments (2)

bootman_mockup.png​ (35.3 KB ) - added by diver 13 years ago.
0001-add-the-drive-s-icon-in-front-of-its-name-in-drive-l.patch​ (2.5 KB ) - added by frizer23 10 years ago.

Download all attachments as: .zip

Change History (11)

by diver, 13 years ago

Attachment: bootman_mockup.png​ added

comment:1 by laplace, 13 years ago

Cc: axeld added

comment:2 by laplace, 13 years ago

Owner: changed from laplace to axeld
Status: new → assigned

Reassigned to Axel, as I am not sure, if CC did work.

comment:3 by diver, 13 years ago

In case there are several identical drives it would be nice to show hard drive model somewhere (tooltip?) to distinguish them.

comment:4 by diver, 13 years ago

Ah, it's already the case since hrev40231 :-)

comment:5 by diver, 13 years ago

On the second thought if drives are identical then models would be identical too. That's when serial numbers could come into play.

by frizer23, 10 years ago

Attachment: 0001-add-the-drive-s-icon-in-front-of-its-name-in-drive-l.patch​ added

comment:6 by frizer23, 10 years ago

patch: 0 → 1

comment:7 by stippi, 10 years ago

Thanks for the patch! It looks good, but you need to delete fIcon in the destructor. Also, if device.GetIcon() fails (it has a return code, I believe), you could memset(fIcon->Bits(), 0, fIcon->BitsLength()) to draw a transparent icon.

comment:8 by jessicah, 10 years ago

Resolution: → fixed
Status: assigned → closed

Applied in hrev47869, including fixes recommended by stippi.

comment:9 by korli, 10 years ago

Still the include order is wrong :)

Note: See TracTickets for help on using tickets.