Tracker and Terminal show the wrong file dates on NTFS volume

[Disreali]

Experienced on 40230-2h, but it has been happening for some time, though I can't remember how long.

Both Tracker and Terminal show the wrong modification dates for files on my WinXP volume formated with NTFS.

[richienyhus]

I had this back in hrev40074.

[stargatefan]

It has been an issue since at least 38xxx

[Disreali]

Still present on hrev40500.

[korli]

The obvious bug is at the following lines in src/add-ons/kernel/file_systems/ntfs/fs_func.c in fs_rstat():

        stbuf->st_atime = ni->last_access_time;
        stbuf->st_ctime = ni->last_mft_change_time;
        stbuf->st_mtime = ni->last_data_change_time;

st_atime, st_ctime, st_mtime are actually time_t

#define st_atime        st_atim.tv_sec
#define st_mtime        st_mtim.tv_sec
#define st_ctime        st_ctim.tv_sec

The code should look like the following, unless I miss something. ntfs2timespec is available in ntfstime.h.

    stbuf->st_atim = ntfs2timespec(ni->last_access_time);
    stbuf->st_mtim = ntfs2timespec(ni->last_data_change_time);
    stbuf->st_ctim = ntfs2timespec(ni->last_mft_change_time);

[bonefish]

Replying to korli:

The code should look like the following, unless I miss something. ntfs2timespec is available in ntfstime.h.

    stbuf->st_atim = ntfs2timespec(ni->last_access_time);
    stbuf->st_mtim = ntfs2timespec(ni->last_data_change_time);
    stbuf->st_ctim = ntfs2timespec(ni->last_mft_change_time);

Agreed. NTFS times seem to be in 1/10 microseconds with another base, so some kind of conversion is needed. And although ATM it is not strictly necessary to set the nanoseconds fields (the ​VFS clears them) the suggested solution also makes use of the additional precision, which is definitely the best thing to do.

[korli]

Fixed in hrev40536.

[Disreali]

Confirmed. Thanks