Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#7134 closed enhancement (fixed)

Message > Save address only searches in boot volume

Reported by: jalopeura Owned by: phoudoin
Priority: normal Milestone: R1
Component: Applications/Mail Version: R1/Development
Keywords: address people Cc: jalopeura@…
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

The "Save address" functionality searches for an existing Person with that address before creating a new one, but it only searches the boot volume.

I keep my people and mail files on a different BFS partition, so I can completely wipe out my boot volume without losing any essential data. So this menu item keeps creating a new Person, even when I have an existing Person with that email address.

I have attached a patch that searches all BFS volumes. (Well, technically, all volumes for which BVolume::KnowsQuery() returns true, which I believe is just BFS volumes.)

Attachments (1)

diff.txt (1.8 KB) - added by jalopeura 8 years ago.
Patch

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by jalopeura

Attachment: diff.txt added

Patch

comment:1 Changed 8 years ago by jalopeura

Has a Patch: set

comment:2 Changed 8 years ago by phoudoin

Owner: changed from bga to phoudoin
Status: newassigned

Patch looks good. I'll apply it soon.

comment:3 Changed 8 years ago by phoudoin

Resolution: fixed
Status: assignedclosed

Patch applied in hrev40258. Thanks!

I keep the old predicate string because it can be used as-is to as argument for People app to set new person file email address. Plus the arg string size with == was one byte too short.

Could you tell us what's your actual name so I can add you to AboutSystem contributors list?

comment:4 Changed 8 years ago by jalopeura

My name is Sean Healy.

comment:5 Changed 8 years ago by jalopeura

Cc: jalopeura@… added
Note: See TracTickets for help on using tickets.