Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#722 closed bug (fixed)

usb_hid uses undocumented cbuf API

Reported by: mmlr Owned by: korli
Priority: normal Milestone: R1
Component: System/Kernel Version:
Keywords: Cc: diver
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

The usb_hid input driver uses an undocumented cbuf kernel API on R5 (see src/add-ons/kernel/drivers/input/usb_hid/hid.h). This API is different from the cbuf implementation that is present in the Haiku kernel. It is therefore not possible to build the usb_hid driver with TARGET_PLATFORM=haiku. I defined the following to get it to build:

#define cbuf_init cbuf_get_chain #define cbuf_delete cbuf_free_chain #define cbuf_putn(x, y, z) cbuf_memcpy_to_chain(x, 0, y, z) #define cbuf_getn(x, y, z) cbuf_memcpy_from_chain(x, 0, y, z)

But I highly doubt that it is correct. Especially the cbuf_putn/cbuf_getn which probably should increment/decrement some position variable.

Change History (4)

comment:1 by diver, 13 years ago

Cc: diver added

comment:2 by korli, 13 years ago

Status: newclosed

comment:3 by korli, 13 years ago

fixed in #18392

comment:4 by korli, 13 years ago

Resolution: fixed
Note: See TracTickets for help on using tickets.