A Processcontroller About box font fix

[Karvjorm]

Here is a title font fix for Processcontroller About box.

[siarzhuk]

	BString str1(B_TRANSLATE("ProcessController")); 
	BAlert *alert = new BAlert(B_TRANSLATE("about"), 
	        B_TRANSLATE("ProcessController\n\n" 
	                    "Copyright 1997-2001,\n"

Some remarks:

1) Variable names must be descriptive - this is the requirement of our coding guidelines. I found "str1" is not a descriptive one. May be "appName", "title", "name" make your code a bit better?
2) There is [theoretical] possibility to break the font style selection by translating first line differently than the beginning of the second line. So I preferred for my syslog_daemon changes using additional snprintf parameter during composing the Alert text. But, this one is not the case, I think - adding additional formatting call will make the code a bit complicate so actual version looks OK in this place. This is just for your information. ;-)

[Karvjorm]

An updated ProcessController localization fix

[Karvjorm]

Reason for the fix

[Karvjorm]

Replying to siarzhuk:

Some remarks:

1) Variable names must be descriptive - this is the requirement of our coding guidelines. I found "str1" is not a descriptive one. May be "appName", "title", "name" make your code a bit better?
2) There is [theoretical] possibility to break the font style selection by translating first line differently than the beginning of the second line. So I preferred for my syslog_daemon changes using additional snprintf parameter during composing the Alert text. But, this one is not the case, I think - adding additional formatting call will make the code a bit complicate so actual version looks OK in this place. This is just for your information. ;-)

I coded that patch a bit stupid. That str1 should have not used at all, as you can see about this updated patch.

br, Karvjorm

[siarzhuk]

Applied in hrev40558. Thanks.

[diver]

Something is still wrong.

[siarzhuk]

Replying to diver:

Something is still wrong.

Fixed in hrev40559. Please check. Thank you for the pointing.