Opened 9 years ago

Closed 9 years ago

#7275 closed enhancement (fixed)

Changing About boxes similar

Reported by: Karvjorm Owned by: nobody
Priority: normal Milestone: R1
Component: - General Version: R1/alpha2
Keywords: Applications Preferences Cc: Karvjorm
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

A minor problem is just now, that all About boxes do not look similar when viewing them. Some have Bold title and some have not.

In the following applications bold title is missing:

CodyCam
DeskCalc (patch included in this ticket)
Magnify! (patch included in this ticket)
MediaConverter (patch included in this ticket)
MediaPlayer (patch included in this ticket)
Terminal
TV (patch included in this ticket)
WebPositive #7210 not implemented yet

And in the following preferences:

Filetypes (patch included in this ticket)
Shortcuts (patch included in this ticket)

In the following applications About box is missing:

DiskUsage
DriveSetup
Icon-O-Matic
Installer
MidiPlayer
People
Screenshot
StyleEdit

And most Preferences are without About box.

Attachments (15)

magnify-about-update.patch (1.3 KB ) - added by Karvjorm 9 years ago.
A About box update for Magnify! application
mediaconverter-about-update.patch (3.1 KB ) - added by Karvjorm 9 years ago.
An About box update for MediaConverter application.
mediaconverter-about-update.2.patch (3.1 KB ) - added by Karvjorm 9 years ago.
An About box update for MediaConverter application.
mediaplayer-about-update.patch (4.6 KB ) - added by Karvjorm 9 years ago.
About box update for the MediaPlayer Application
shortcuts-about-update.patch (2.3 KB ) - added by Karvjorm 9 years ago.
About box update for the Shortcuts preferences
filetypes-about-update.patch (601 bytes ) - added by Karvjorm 9 years ago.
About box update for the FileTypes preferences
filetypes-about-update.2.patch (601 bytes ) - added by Karvjorm 9 years ago.
About box update for the FileTypes preferences
filetypes-about-update.3.patch (601 bytes ) - added by Karvjorm 9 years ago.
About box update for the FileTypes preferences
filetypes-about-update.4.patch (601 bytes ) - added by Karvjorm 9 years ago.
About box update for the FileTypes preferences
filetypes-about-update.5.patch (601 bytes ) - added by Karvjorm 9 years ago.
About box update for the FileTypes preferences
filetypes-about-update.6.patch (601 bytes ) - added by Karvjorm 9 years ago.
About box update for the FileTypes preferences
filetypes-about-update.7.patch (601 bytes ) - added by Karvjorm 9 years ago.
About box update for the FileTypes preferences
tv-about-update.patch (1.2 KB ) - added by Karvjorm 9 years ago.
About box update for the TV application
deskcalc-about-update.patch (1.6 KB ) - added by Karvjorm 9 years ago.
An updated About box update for the DeskCalc application
codycam-about-update.patch (1.2 KB ) - added by Karvjorm 9 years ago.
About box update for the CodyCam application

Download all attachments as: .zip

Change History (20)

comment:1 by Karvjorm, 9 years ago

Has a Patch: set

by Karvjorm, 9 years ago

Attachment: magnify-about-update.patch added

A About box update for Magnify! application

by Karvjorm, 9 years ago

An About box update for MediaConverter application.

by Karvjorm, 9 years ago

An About box update for MediaConverter application.

by Karvjorm, 9 years ago

About box update for the MediaPlayer Application

by Karvjorm, 9 years ago

About box update for the Shortcuts preferences

by Karvjorm, 9 years ago

About box update for the FileTypes preferences

by Karvjorm, 9 years ago

About box update for the FileTypes preferences

by Karvjorm, 9 years ago

About box update for the FileTypes preferences

by Karvjorm, 9 years ago

About box update for the FileTypes preferences

by Karvjorm, 9 years ago

About box update for the FileTypes preferences

by Karvjorm, 9 years ago

About box update for the FileTypes preferences

by Karvjorm, 9 years ago

About box update for the FileTypes preferences

comment:2 by Karvjorm, 9 years ago

For some reason WebPositive saves (and posts) several copies of a single patch. Sorry.

by Karvjorm, 9 years ago

Attachment: tv-about-update.patch added

About box update for the TV application

by Karvjorm, 9 years ago

Attachment: deskcalc-about-update.patch added

An updated About box update for the DeskCalc application

by Karvjorm, 9 years ago

Attachment: codycam-about-update.patch added

About box update for the CodyCam application

comment:3 by axeld, 9 years ago

Thanks for your hard work! However, we have a private BAboutWindow class (see headers/private/shared) that would be the preferred way for all applications that use the standard BAlert way in the long run.

I wouldn't mind to see your patch being committed for now, though; I've only skimmed over it so far, though, there a few style violations, but only minor things.

comment:4 by Karvjorm, 9 years ago

You're welcome.

BTW, I added an ESCAPE shortcut to CodyCam and to some other patch too. I think that it is a fine to close About window by Esc button, so I should have put the line

alert->SetShortcut(0, B_ESCAPE);

to all of them.

comment:5 by jonas.kirilla, 9 years ago

Resolution: fixed
Status: newclosed

About-windows were removed from apps and preferences in hrev41108, hrev41115 and hrev41128. I'm sorry about the work being lost. :I On the upside it means less code to maintain.

Note: See TracTickets for help on using tickets.